fix: release comms-blocking parks when replies arrive and give every role file authoring tools
Project 3333 forensics: env_engineer sent a blocking question to the CTO, got a full reply 96s later, and still deadlocked the whole run — the park half (`_park_for_blocking_comms`) had no wired consumer, so WAITING_FOR_PEER work items could never be released. Unpark path (root fix): - The dispatcher loop now calls `_try_unpark_blocking_comms` each tick for parked, non-in-flight tasks; blocking replies land as durable inbox files, so the check is read-only until all replies are present. - `_try_unpark_blocking_comms` accepts orphaned waits (peer_wait stripped by the legacy resolver while the work item stayed parked) and falls back to the park predicate itself: an empty unresolved blocking outbox releases the task, anything pending keeps it parked. - `resolve_task_peer_wait` no longer touches comms_blocking waits (it flipped task.status without the work-item phase and stripped the peer_wait evidence); `_resume_peer_checkpoint` re-enters the company runtime for comms/orphaned waits and lets the dispatcher converge. File tools (defaults changed at their declaration sites, honoring the "empty tools = everything, explicit list = exactly that" contract): - corporate builtin groups gain file_write/file_edit for coordination, QA, and data-acquisition roles. - all shipped org YAML role tool lists gain the missing file_write/file_edit entries. - coordination turn modes no longer strip file_write/file_edit at runtime — in-context content (briefs, matrices) must be persistable instead of getting trapped in blocking DM hand-offs. Also includes the pending office_ui ws_handler change from the working tree. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This commit is contained in:
@@ -1989,6 +1989,11 @@ class CommunicationManager:
|
||||
wait = dict(task.metadata.get("peer_wait", {}))
|
||||
if not wait:
|
||||
return False
|
||||
if str(wait.get("kind") or "") == "comms_blocking":
|
||||
# File-comms blocking waits are owned by the company
|
||||
# dispatcher's per-tick unpark; resolving them here would flip
|
||||
# task.status without the work-item phase and strand the run.
|
||||
return False
|
||||
if wait.get("kind") != "meeting":
|
||||
msg_id = wait.get("message_id")
|
||||
reply = await self.store.get_latest_reply(msg_id) if msg_id else None
|
||||
|
||||
Reference in New Issue
Block a user