test: repair full suite — hang fix, stale-test updates, patch hygiene, timeout backstop
Suite went from 27 failures plus one permanent hang (never finished) to 1846 passed / 0 failed in ~85s, including under FORCE_COLOR. - office_shutdown_lifecycle: construct WSHandler via the real __init__ (helper) instead of hand-copied __new__ stubs that drift from the constructor (#11 added _runtime_status_sync_task and the stubs hung); the formerly-hanging wait now has a 5s wait_for. - import-time patch hygiene: company_recruiter / company_reorg / engine_session_defaults replaced module-level permanent tempfile.TemporaryDirectory monkeypatching with paired setUpModule/tearDownModule, fixing order-dependent sqlite failures in transcript_pagination during full runs. - stale tests updated to current product semantics: resume stubs use status="done" (failed is deliberately non-resumable), fix4 asserts the native review contract through build_company_work_item_contract, delivery fixture carries user_visible/feedback_scope=final, ownership doc names progress_log, session compression calls maybe_compact_session(force=True) explicitly, hard delete removes the work item row, parallel-isolation asserts delegate rebind and stubs _get_project_delegate, role update goes through OrgService on an editable custom org (plus read-only rejection case), collab_rpc patches the single os.name decision point instead of poisoning pathlib, codex no-pty builds inside the patch, identity-guard false positives reworded. - cli_board actions rewritten against the real OfficeServiceFactory seam with a tempdir OPC_HOME (old direct-engine stubs were never consulted and the tests wrote into the real OPC home). - cli_app assertions strip ANSI via _plain_output so a color-forcing shell (FORCE_COLOR) cannot break plain-text expectations. - deleted never-runnable test_org_concurrency (pytest.mark.asyncio without the plugin, stdlib-only assertions) and three dead skipped filesystem-handoff tests. - pyproject: dev extra (pytest, pytest-timeout) and a 300s per-test timeout backstop so a wedged test fails instead of stalling the suite. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This commit is contained in:
@@ -131,11 +131,22 @@ class CollaborationRpcTransportTests(unittest.IsolatedAsyncioTestCase):
|
||||
)
|
||||
parser = cli_collab._build_parser()
|
||||
opts = parser.parse_args(["delegate_work", "--args-json-file", str(args_path)])
|
||||
with patch.object(cli_collab.os, "name", "nt"), patch.dict(
|
||||
# Simulate os.name == "nt" only at the product's single decision
|
||||
# point instead of patching the global os.name, which would turn
|
||||
# every pathlib.Path in this process into a WindowsPath and break
|
||||
# the POSIX file reads the test itself performs. The real
|
||||
# rpc_env_configured() check still runs against the patched env,
|
||||
# so the Windows guard branch is exercised end to end.
|
||||
with patch.object(
|
||||
cli_collab,
|
||||
"_windows_external_rpc_env_configured",
|
||||
lambda: rpc_env_configured(),
|
||||
), patch.dict(
|
||||
"os.environ",
|
||||
server.client_env,
|
||||
clear=True,
|
||||
):
|
||||
self.assertTrue(cli_collab._windows_external_rpc_env_configured())
|
||||
tool_args = cli_collab._collect_tool_args(opts)
|
||||
payload, is_error = await cli_collab._dispatch(opts.tool, tool_args)
|
||||
finally:
|
||||
|
||||
Reference in New Issue
Block a user