test: repair full suite — hang fix, stale-test updates, patch hygiene, timeout backstop

Suite went from 27 failures plus one permanent hang (never finished) to
1846 passed / 0 failed in ~85s, including under FORCE_COLOR.

- office_shutdown_lifecycle: construct WSHandler via the real __init__
  (helper) instead of hand-copied __new__ stubs that drift from the
  constructor (#11 added _runtime_status_sync_task and the stubs hung);
  the formerly-hanging wait now has a 5s wait_for.
- import-time patch hygiene: company_recruiter / company_reorg /
  engine_session_defaults replaced module-level permanent
  tempfile.TemporaryDirectory monkeypatching with paired
  setUpModule/tearDownModule, fixing order-dependent sqlite failures in
  transcript_pagination during full runs.
- stale tests updated to current product semantics: resume stubs use
  status="done" (failed is deliberately non-resumable), fix4 asserts the
  native review contract through build_company_work_item_contract,
  delivery fixture carries user_visible/feedback_scope=final, ownership
  doc names progress_log, session compression calls
  maybe_compact_session(force=True) explicitly, hard delete removes the
  work item row, parallel-isolation asserts delegate rebind and stubs
  _get_project_delegate, role update goes through OrgService on an
  editable custom org (plus read-only rejection case), collab_rpc patches
  the single os.name decision point instead of poisoning pathlib, codex
  no-pty builds inside the patch, identity-guard false positives reworded.
- cli_board actions rewritten against the real OfficeServiceFactory seam
  with a tempdir OPC_HOME (old direct-engine stubs were never consulted
  and the tests wrote into the real OPC home).
- cli_app assertions strip ANSI via _plain_output so a color-forcing
  shell (FORCE_COLOR) cannot break plain-text expectations.
- deleted never-runnable test_org_concurrency (pytest.mark.asyncio
  without the plugin, stdlib-only assertions) and three dead skipped
  filesystem-handoff tests.
- pyproject: dev extra (pytest, pytest-timeout) and a 300s per-test
  timeout backstop so a wedged test fails instead of stalling the suite.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This commit is contained in:
LZH-YS1998
2026-07-26 22:14:47 +08:00
parent 9977c3be57
commit 76c530a9e5
20 changed files with 424 additions and 447 deletions
+10 -2
View File
@@ -18,7 +18,7 @@ import tempfile
import unittest
from pathlib import Path
from opc.core.models import DelegationWorkItem, Phase, RoleRuntimeSession
from opc.core.models import DelegationWorkItem, Phase, RoleRuntimeSession, Task
from opc.database.store import OPCStore
from opc.layer2_organization import phase_hooks # noqa: F401 (register hooks)
from opc.layer3_agent.adapters.base import ExternalAgentAdapter
@@ -126,7 +126,15 @@ class ReviewPromptSchemaTests(unittest.TestCase):
self.assertNotIn("auto-rejected", text.lower())
def test_native_agent_prompt_keeps_suggested_schema(self) -> None:
text = native_agent._COMPANY_REVIEW_WORK_ITEM_GUIDELINES
# The guidelines live in company_runtime_contract; the native agent
# injects them through build_company_work_item_contract, so assert
# through the wiring the native agent actually uses.
task = Task(
id="review-task",
title="Review work item",
metadata={"work_item_turn_type": "review"},
)
text = native_agent.build_company_work_item_contract(task)
self.assertIn("review_verdict", text)
self.assertIn("blocking_issues", text)
self.assertNotIn("Mandatory verdict schema", text)