test: repair full suite — hang fix, stale-test updates, patch hygiene, timeout backstop
Suite went from 27 failures plus one permanent hang (never finished) to 1846 passed / 0 failed in ~85s, including under FORCE_COLOR. - office_shutdown_lifecycle: construct WSHandler via the real __init__ (helper) instead of hand-copied __new__ stubs that drift from the constructor (#11 added _runtime_status_sync_task and the stubs hung); the formerly-hanging wait now has a 5s wait_for. - import-time patch hygiene: company_recruiter / company_reorg / engine_session_defaults replaced module-level permanent tempfile.TemporaryDirectory monkeypatching with paired setUpModule/tearDownModule, fixing order-dependent sqlite failures in transcript_pagination during full runs. - stale tests updated to current product semantics: resume stubs use status="done" (failed is deliberately non-resumable), fix4 asserts the native review contract through build_company_work_item_contract, delivery fixture carries user_visible/feedback_scope=final, ownership doc names progress_log, session compression calls maybe_compact_session(force=True) explicitly, hard delete removes the work item row, parallel-isolation asserts delegate rebind and stubs _get_project_delegate, role update goes through OrgService on an editable custom org (plus read-only rejection case), collab_rpc patches the single os.name decision point instead of poisoning pathlib, codex no-pty builds inside the patch, identity-guard false positives reworded. - cli_board actions rewritten against the real OfficeServiceFactory seam with a tempdir OPC_HOME (old direct-engine stubs were never consulted and the tests wrote into the real OPC home). - cli_app assertions strip ANSI via _plain_output so a color-forcing shell (FORCE_COLOR) cannot break plain-text expectations. - deleted never-runnable test_org_concurrency (pytest.mark.asyncio without the plugin, stdlib-only assertions) and three dead skipped filesystem-handoff tests. - pyproject: dev extra (pytest, pytest-timeout) and a 300s per-test timeout backstop so a wedged test fails instead of stalling the suite. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This commit is contained in:
@@ -328,7 +328,7 @@ class WorkItemRuntimeLinkTests(unittest.IsolatedAsyncioTestCase):
|
||||
{item.work_item_id: canonical.id},
|
||||
)
|
||||
|
||||
async def test_task_delete_cascades_link_and_allows_rematerialization(self) -> None:
|
||||
async def test_task_delete_cascades_link_and_work_item_row(self) -> None:
|
||||
item = _work_item("wi-cascade")
|
||||
task = _task("task-cascade")
|
||||
await self.store.save_delegation_work_item(item)
|
||||
@@ -337,10 +337,13 @@ class WorkItemRuntimeLinkTests(unittest.IsolatedAsyncioTestCase):
|
||||
|
||||
await self.store.hard_delete_task(task.id)
|
||||
|
||||
# Hard delete removes the linked work item row together with the
|
||||
# runtime traces, so the identity cannot be rematerialized.
|
||||
self.assertEqual(await self.store.get_runtime_links_for_work_items([item.work_item_id]), {})
|
||||
self.assertIsNone(await self.store.get_delegation_work_item(item.work_item_id))
|
||||
replacement = _task("task-cascade-replacement")
|
||||
await self.store.save_task(replacement)
|
||||
self.assertTrue(await self.store.link_work_item_runtime_task(item.work_item_id, replacement.id))
|
||||
self.assertFalse(await self.store.link_work_item_runtime_task(item.work_item_id, replacement.id))
|
||||
|
||||
async def test_transition_from_task_uses_structured_link_without_legacy_metadata(self) -> None:
|
||||
item = _work_item("wi-transition")
|
||||
|
||||
Reference in New Issue
Block a user