mirror of
https://github.com/Tencent/BrowserSkill.git
synced 2026-09-10 13:01:23 +08:00
test(fill): cover caret positioning and clarify append behavior
This commit is contained in:
1 parent
f2184e74c5
commit
321494d93f
2 files changed
+49
-10
No files matched your search
@@ -35,13 +35,24 @@ async function setup(markup = '<input value="old">') {
|
|||||||
return { exceptionDetails: { text: "test page script failed" } };
|
return { exceptionDetails: { text: "test page script failed" } };
|
||||||
}
|
}
|
||||||
});
|
});
|
||||||
|
// Number/email controls have a browser caret even though their selection
|
||||||
|
// getters return null. Model that caret instead of assuming it is at the end.
|
||||||
|
const hiddenCaret = { start: 0, end: 0 };
|
||||||
|
const moveToEnd = vi.fn(async () => {
|
||||||
|
if (typeof element.selectionStart === "number") {
|
||||||
|
element.setSelectionRange(element.value.length, element.value.length);
|
||||||
|
} else {
|
||||||
|
hiddenCaret.start = hiddenCaret.end = element.value.length;
|
||||||
|
}
|
||||||
|
});
|
||||||
const insert = vi.fn(async (text: string) => {
|
const insert = vi.fn(async (text: string) => {
|
||||||
const focused = document.activeElement as HTMLInputElement;
|
const focused = document.activeElement as HTMLInputElement;
|
||||||
if (focused.readOnly || focused.disabled) return;
|
if (focused.readOnly || focused.disabled) return;
|
||||||
const start = focused.selectionStart ?? focused.value.length;
|
const start = focused.selectionStart ?? hiddenCaret.start;
|
||||||
const end = focused.selectionEnd ?? start;
|
const end = focused.selectionEnd ?? hiddenCaret.end;
|
||||||
const value = focused.value.slice(0, start) + text + focused.value.slice(end);
|
const value = focused.value.slice(0, start) + text + focused.value.slice(end);
|
||||||
focused.value = focused.maxLength >= 0 ? value.slice(0, focused.maxLength) : value;
|
focused.value = focused.maxLength >= 0 ? value.slice(0, focused.maxLength) : value;
|
||||||
|
hiddenCaret.start = hiddenCaret.end = Math.min(start + text.length, focused.value.length);
|
||||||
focused.dispatchEvent(new Event("input", { bubbles: true }));
|
focused.dispatchEvent(new Event("input", { bubbles: true }));
|
||||||
});
|
});
|
||||||
const release = vi.fn(async () => ({}));
|
const release = vi.fn(async () => ({}));
|
||||||
@@ -68,9 +79,7 @@ async function setup(markup = '<input value="old">') {
|
|||||||
return {};
|
return {};
|
||||||
case "Input.dispatchKeyEvent":
|
case "Input.dispatchKeyEvent":
|
||||||
if ((params as { commands?: string[] }).commands?.includes("moveToEndOfDocument")) {
|
if ((params as { commands?: string[] }).commands?.includes("moveToEndOfDocument")) {
|
||||||
if (typeof element.selectionStart === "number") {
|
await moveToEnd();
|
||||||
element.setSelectionRange(element.value.length, element.value.length);
|
|
||||||
}
|
|
||||||
}
|
}
|
||||||
return {};
|
return {};
|
||||||
case "Runtime.releaseObject":
|
case "Runtime.releaseObject":
|
||||||
@@ -81,6 +90,8 @@ async function setup(markup = '<input value="old">') {
|
|||||||
});
|
});
|
||||||
return {
|
return {
|
||||||
element,
|
element,
|
||||||
|
hiddenCaret,
|
||||||
|
moveToEnd,
|
||||||
script,
|
script,
|
||||||
insert,
|
insert,
|
||||||
release,
|
release,
|
||||||
@@ -410,11 +421,21 @@ describe("fill result verification", () => {
|
|||||||
expect(h.element.value).toBe("old🙂");
|
expect(h.element.value).toBe("old🙂");
|
||||||
});
|
});
|
||||||
|
|
||||||
it.each([
|
it.each(
|
||||||
"number",
|
["number", "email"].flatMap((type) =>
|
||||||
"email",
|
[
|
||||||
])("appends to %s without setting an unsupported selection API", async (type) => {
|
[0, 0],
|
||||||
|
[1, 1],
|
||||||
|
[0, 2],
|
||||||
|
].map(([start, end]) => ({ type, start, end })),
|
||||||
|
),
|
||||||
|
)("appends to $type from selection $start:$end without using its unsupported API", async ({
|
||||||
|
type,
|
||||||
|
start,
|
||||||
|
end,
|
||||||
|
}) => {
|
||||||
const h = await setup(`<input type="${type}" value="12">`);
|
const h = await setup(`<input type="${type}" value="12">`);
|
||||||
|
Object.assign(h.hiddenCaret, { start, end });
|
||||||
vi.spyOn(h.element, "selectionStart", "get").mockReturnValue(null);
|
vi.spyOn(h.element, "selectionStart", "get").mockReturnValue(null);
|
||||||
vi.spyOn(h.element, "selectionEnd", "get").mockReturnValue(null);
|
vi.spyOn(h.element, "selectionEnd", "get").mockReturnValue(null);
|
||||||
const selection = vi.spyOn(h.element, "setSelectionRange").mockImplementation(() => {
|
const selection = vi.spyOn(h.element, "setSelectionRange").mockImplementation(() => {
|
||||||
@@ -425,6 +446,22 @@ describe("fill result verification", () => {
|
|||||||
expect(selection).not.toHaveBeenCalled();
|
expect(selection).not.toHaveBeenCalled();
|
||||||
});
|
});
|
||||||
|
|
||||||
|
it.each([
|
||||||
|
"number",
|
||||||
|
"email",
|
||||||
|
])("does not report successful %s append when the caret command is ignored", async (type) => {
|
||||||
|
const h = await setup(`<input type="${type}" value="12">`);
|
||||||
|
vi.spyOn(h.element, "selectionStart", "get").mockReturnValue(null);
|
||||||
|
vi.spyOn(h.element, "selectionEnd", "get").mockReturnValue(null);
|
||||||
|
h.moveToEnd.mockResolvedValueOnce(undefined);
|
||||||
|
expect(await h.fill("3", false)).toMatchObject({
|
||||||
|
code: "cdp_failed",
|
||||||
|
data: { reason: "fill_value_mismatch" },
|
||||||
|
});
|
||||||
|
expect(h.element.value).toBe("312");
|
||||||
|
expect(h.insert).toHaveBeenCalledOnce();
|
||||||
|
});
|
||||||
|
|
||||||
it("rejects invalid number text before clearing", async () => {
|
it("rejects invalid number text before clearing", async () => {
|
||||||
const h = await setup('<input type="number" value="12">');
|
const h = await setup('<input type="number" value="12">');
|
||||||
expect(await h.fill("abc")).toMatchObject({
|
expect(await h.fill("abc")).toMatchObject({
|
||||||
|
|||||||
@@ -636,7 +636,9 @@ function defineBrowserOperations(deps: ToolDeps, register: DefinitionRegistrar):
|
|||||||
session: SESSION_PARAM,
|
session: SESSION_PARAM,
|
||||||
noClear: {
|
noClear: {
|
||||||
type: "boolean",
|
type: "boolean",
|
||||||
description: "Skip the default wipe-the-field-first pass (append instead).",
|
description:
|
||||||
|
"Append to the end of the existing value instead of clearing it. " +
|
||||||
|
"The tool moves the caret automatically; no prior click or selection is needed.",
|
||||||
},
|
},
|
||||||
},
|
},
|
||||||
output: {
|
output: {
|
||||||
|
|||||||
Reference in new issue
Block a user