figmar/BrowserSkill
1
0
Fork 0
mirror of https://github.com/Tencent/BrowserSkill.git synced 2026-09-10 13:01:23 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix(runtime): fix early control return and update lifecycle

Browse Source
This commit is contained in:
Ljy-0827
2026-07-24 14:07:33 +08:00
parent c8963e3a68
commit 4e44fb2823
17 changed files with 1002 additions and 262 deletions
Download Patch File Download Diff File Expand all files Collapse all files
apps/extension/src/content/HelpRequestOverlay.tsx
+20 -20
View File
@@ -342,6 +342,8 @@ export function HelpRequestOverlay({ request }: Props) {
z-index: 2147483647;
display: flex;
flex-direction: column;
justify-content: flex-start;
min-height: 0;
gap: 10px;
width: var(--bsk-help-banner-width);
max-width: calc(100vw - ${VIEWPORT_MARGIN * 2}px);
@@ -359,16 +361,18 @@ export function HelpRequestOverlay({ request }: Props) {
.bsk-help-banner[data-collapsed="true"] {
gap: 0;
width: var(--bsk-help-banner-width);
padding: 10px 12px;
padding: 12px;
}
.bsk-help-drag-strip {
flex-shrink: 0;
position: absolute;
top: 6px;
left: 0;
right: 0;
display: flex;
align-items: center;
justify-content: center;
height: 12px;
margin: -8px 0 -10px;
cursor: grab;
user-select: none;
touch-action: none;
@@ -395,10 +399,11 @@ export function HelpRequestOverlay({ request }: Props) {
}
.bsk-help-banner[data-collapsed="true"] .bsk-help-drag-strip {
margin: -6px 0 -8px;
top: 4px;
}
.bsk-help-header {
flex-shrink: 0;
display: flex;
align-items: center;
gap: 10px;
@@ -420,25 +425,17 @@ export function HelpRequestOverlay({ request }: Props) {
.bsk-help-header-actions {
flex-shrink: 0;
display: flex;
display: none;
align-items: center;
gap: 10px;
margin-left: auto;
overflow: hidden;
max-width: 0;
opacity: 0;
transform: translateX(8px);
pointer-events: none;
transition:
max-width var(--bsk-help-duration) var(--bsk-help-ease),
opacity 220ms var(--bsk-help-ease),
transform var(--bsk-help-duration) var(--bsk-help-ease);
}
.bsk-help-banner[data-collapsed="true"] .bsk-help-header-actions {
display: flex;
max-width: 280px;
opacity: 1;
transform: translateX(0);
pointer-events: auto;
}
@@ -471,15 +468,13 @@ export function HelpRequestOverlay({ request }: Props) {
}
.bsk-help-body {
display: grid;
grid-template-rows: 1fr;
display: block;
flex-shrink: 0;
min-width: 0;
transition: grid-template-rows var(--bsk-help-duration) var(--bsk-help-ease);
}
.bsk-help-banner[data-collapsed="true"] .bsk-help-body {
position: absolute;
grid-template-rows: 0fr;
width: 0;
height: 0;
overflow: hidden;
@@ -528,6 +523,7 @@ export function HelpRequestOverlay({ request }: Props) {
.bsk-help-footer-actions {
display: flex;
justify-content: flex-end;
flex-wrap: wrap;
gap: 10px;
}
@@ -539,7 +535,8 @@ export function HelpRequestOverlay({ request }: Props) {
font-size: 13px;
font-weight: 500;
color: #4b5563;
flex-shrink: 0;
min-width: 0;
white-space: normal;
}
.bsk-help-btn-continue {
@@ -550,16 +547,19 @@ export function HelpRequestOverlay({ request }: Props) {
font-size: 13px;
font-weight: 600;
color: #fff;
flex-shrink: 0;
min-width: 0;
white-space: normal;
}
.bsk-help-header-actions .bsk-help-btn-cancel,
.bsk-help-header-actions .bsk-help-btn-continue {
padding: 6px 12px;
white-space: nowrap;
}
.bsk-help-header-actions .bsk-help-btn-continue {
padding: 6px 14px;
max-width: 180px;
}
.bsk-help-footer-actions .bsk-help-btn-cancel {
apps/extension/src/content/__tests__/HelpRequestOverlay.test.tsx
+9
View File
@@ -204,6 +204,15 @@ describe("HelpRequestOverlay", () => {
expect(styles).toContain("width: 0");
});
it("uses natural body height in the expanded layout", () => {
const { container } = renderOverlay(baseRequest());
const styles = overlayStyles(container);
expect(styles).toMatch(/\.bsk-help-body\s*\{[^}]*display:\s*block;/s);
expect(styles).not.toMatch(/\.bsk-help-body\s*\{[^}]*grid-template-rows/s);
expect(styles).toMatch(/\.bsk-help-banner\s*\{[^}]*justify-content:\s*flex-start;/s);
});
it("keeps the same banner width when collapsed", () => {
const { container } = renderOverlay(baseRequest());
const styles = overlayStyles(container);