fix(dsh-plugin): add PiP close button and sniff observation thumbnail media type

The Document PiP window had no close/return entry once popped out —
users could not dismiss it from inside the window. Add an onClosePip
callback and render a close button in the PiP header; clicking it
calls pipWindow.close() and the content returns to its carrier.

The observation thumbnail publisher hardcoded mediaType as "image/png"
regardless of the actual capture bytes. Reuse the existing
sniffImageMediaType helper (exported from image.ts) so the HTTP
thumbnail endpoint declares the correct Content-Type when Chromium
returns JPEG captures.

Closes #153 (Bug 2 fully; Bug 1 was fixed in #135, this covers the
remaining observation-thumbnail path).

Co-authored-by: Cursor <cursoragent@cursor.com>
This commit is contained in:
drakezhang
2026-09-02 16:14:24 +08:00
co-authored by Cursor
parent 49744233f7
commit 51473c01ff
6 changed files with 58 additions and 2 deletions
@@ -14,6 +14,7 @@ import { cn } from "@browser-skill/ui";
import {
RiArrowDownSLine,
RiCheckLine,
RiCloseLine,
RiCloseCircleLine,
RiErrorWarningLine,
RiPictureInPicture2Line,
@@ -28,6 +29,7 @@ const asIcon = (component: unknown): IconComponent => component as IconComponent
const IconStop = asIcon(RiStopCircleLine);
const IconPip = asIcon(RiPictureInPicture2Line);
const IconDown = asIcon(RiArrowDownSLine);
const IconClose = asIcon(RiCloseLine);
const IconWarn = asIcon(RiErrorWarningLine);
const IconPin = asIcon(RiPushpinFill);
const IconCloseSession = asIcon(RiCloseCircleLine);
@@ -320,6 +322,7 @@ export function OverlayBody(props: {
now: number;
onPopOut?: (() => void) | undefined;
onCollapse?: (() => void) | undefined;
onClosePip?: (() => void) | undefined;
inPip: boolean;
onHeaderPointerDown?: (event: ReactPointerEvent<HTMLDivElement>) => void;
}) {
@@ -333,6 +336,7 @@ export function OverlayBody(props: {
now,
onPopOut,
onCollapse,
onClosePip,
inPip,
onHeaderPointerDown,
} = props;
@@ -389,6 +393,16 @@ export function OverlayBody(props: {
<IconDown size={14} />
</button>
) : null}
{onClosePip !== undefined ? (
<button
type="button"
className={css["icon-button"]}
aria-label="Close mini window"
onClick={onClosePip}
>
<IconClose size={14} />
</button>
) : null}
</div>
<div className={css.stage}>
{displayUrl !== undefined ? (
@@ -572,6 +586,7 @@ export function ObservationOverlay({ store }: { store: ObservationClientStore })
: undefined
}
onCollapse={pipWindow === null ? () => setCollapsed(true) : undefined}
onClosePip={pipWindow !== null ? () => pipWindow.close() : undefined}
onHeaderPointerDown={pipWindow === null ? beginMove : undefined}
/>
);
@@ -149,6 +149,7 @@ export function ObservationSidebarTab({
now={now}
inPip={pipWindow !== null}
onPopOut={pipWindow === null && pipSupported ? () => popOut() : undefined}
onClosePip={pipWindow !== null ? () => pipWindow.close() : undefined}
/>
);