feat(dsh): adapt to DSH 0.1.5-rc.1 and restore the guide description
Baseline moves to DSH 0.1.5-rc.1 — the 0.1.5 line's first release candidate, and the npm `latest` dist-tag now: peer floor ^0.1.5-rc.1, devDependency pins, the CI mount-lane pin and dsh.plugin.json engines all follow. 0.1.5-alpha.2 users stay on v0.19.0-alpha.1. The upstream delta from alpha.2 is small: 373 changed files, mostly version bumps, sidebar preview polish and test snapshots. Exactly two changes touch this plugin, and only one needs work: - `SidebarRightGuideEntry.description` is back (optional). The native guide renders it only while it lists at most 4 entries; a longer list drops every description. The plugin restores `TabDescriptor.description` and the six built-in `guideDesc*` lines (20 dictionaries) verbatim from 0b6ac5d^, but deliberately does NOT restore the old generic `nativeGuideDesc` fallback: the host has no fallback of its own, so a descriptor that declares none now ships no `description` field at all and renders as a clean title-only capsule. Consequence worth knowing: the plugin contributes six guide entries, so the default composition is over the 4-entry limit and shows titles only. The mount lane proves the restored field end to end by shrinking the enabled set to three types through the plugin's own settings route (scratch profile only) and requiring the Files capsule to grow its line. - The built-in `files` type declares a guide description again and uses a coloured folder glyph; the plugin owns that kind, so nothing to do. Verified unchanged from alpha.2 (so nobody re-checks them): the global main-panel model, the file address grammar (util/workspace-path changed only its package.json), the native tab-body host contract (.paneBody is still a block scroller with a definite height), the core/agent/session/ subagent host APIs and the ui-primitives export surface. Restore caveat fixed in the lane: the settings route merges patches key-wise, so undoing a temporary `tabsEnabled` change by posting the original (empty) map leaves the disabled keys behind — the e2e restores every key it touched explicitly.
This commit is contained in:
1 parent
036a747c80
commit
725b2f7cec
36 files changed
+726
-362
No files matched your search
+22
-5
@@ -45,11 +45,9 @@ describe('built-in tab registrations', () => {
|
||||
})
|
||||
|
||||
it('every visible tab declares a non-empty, mutually distinct title', () => {
|
||||
// The native new-tab list (guide page) is an icon+title capsule at DSH
|
||||
// 0.1.5-alpha.2 — the `description` field is gone from the host contract.
|
||||
// The title is therefore the only per-tab guide text: it must exist, and
|
||||
// no two visible tabs may share one (identical capsules would be
|
||||
// indistinguishable in the guide and the tab strip).
|
||||
// The title is the tab's identity in the native new-tab list (guide
|
||||
// page) and the tab strip: it must exist, and no two visible tabs may
|
||||
// share one (identical capsules would be indistinguishable).
|
||||
const { service } = setup()
|
||||
const visible = service.getTabs().filter(descriptor => descriptor.hidden !== true)
|
||||
expect(visible.length).toBeGreaterThan(0)
|
||||
@@ -62,6 +60,25 @@ describe('built-in tab registrations', () => {
|
||||
expect(new Set(titles).size, 'titles must differ per tab').toBe(visible.length)
|
||||
})
|
||||
|
||||
it('every visible tab declares a non-empty, mutually distinct description', () => {
|
||||
// DSH 0.1.5-rc.1 renders `description` under the title while the guide
|
||||
// lists at most 4 entries (a longer list drops every description). With
|
||||
// the host no longer substituting a generic fallback, a tab without one
|
||||
// renders the title alone — so every visible tab declares the real
|
||||
// purpose of its page, and no two may read identically.
|
||||
const { service } = setup()
|
||||
const visible = service.getTabs().filter(descriptor => descriptor.hidden !== true)
|
||||
expect(visible.length).toBeGreaterThan(0)
|
||||
for (const descriptor of visible) {
|
||||
expect(descriptor.description, `${descriptor.id} must declare a description`).toBeDefined()
|
||||
const line = typeof descriptor.description === 'function' ? descriptor.description() : descriptor.description
|
||||
expect(line, `${descriptor.id} description must be non-empty`).toBeTruthy()
|
||||
}
|
||||
const lines = visible.map(descriptor =>
|
||||
typeof descriptor.description === 'function' ? descriptor.description() : descriptor.description)
|
||||
expect(new Set(lines).size, 'descriptions must differ per tab').toBe(visible.length)
|
||||
})
|
||||
|
||||
it('the changes tab declares no settings of its own (the diff always docks)', () => {
|
||||
const { service } = setup()
|
||||
expect(service.getTab('git')?.settings).toBeUndefined()
|
||||
|
||||
Reference in new issue
Block a user