fix: address Copilot review (9 comments)
#1 GitView: hide/disable 'open in editor' for external linked worktrees (path outside session workspace is rejected by the fence); add isWithinWorkspace client helper for the gate. #2 DiffTab: untracked diff read resolves against diff.repoRoot (child-repo paths are repo-root-relative, not cwd-relative); fs.read route threads selectedRepoOf into resolveGitPath so the host resolves the right base. #3 GitView: chooseRepo handler mirrors chooseWorktree — clears status/ history/log and bumps generation before async refresh, preventing stale rows from acting on the newly selected repository. #4 git.ts: repoRoots/repoRoot compare roots via pathIdentity() (platform- aware) instead of raw includes(), fixing win32 forward/backslash mismatch that silently fell back to roots[0]. #5 markdown-images: mask fenced code blocks and inline code spans before rewriting; only rewrite reference definitions whose label is actually referenced by image syntax (not plain links). +3 tests. #6 package.json: downgrade unrun ^0.3.1 → ^0.2.39 (0.3.x requires Node ^22.13, incompatible with declared engines >=20). #7 market-manifest.spec: shell:true on win32 so execFileSync resolves the pnpm .cmd shim. #8 smoke.spec: build html-route URL via encodeHtmlUrl() (production encoder) so the Windows drive separator is correct. #9 index.ts git.worktrees route: thread selectedRepoOf so a workspace container's selected child repo's linked worktrees appear.
This commit is contained in:
@@ -70,4 +70,31 @@ describe('rewriteLocalImageUrls', () => {
|
||||
expect(url).toContain('/sidebar/file?')
|
||||
expect(decodeURIComponent(url)).toContain('C:\\repo\\img.png')
|
||||
})
|
||||
|
||||
it('does not rewrite image-looking text inside fenced code blocks', () => {
|
||||
const md = '```\n\n```\n'
|
||||
const out = rewriteLocalImageUrls(md, scope, '/repo/readme.md', ORIGIN)
|
||||
// The fenced example must be preserved verbatim; only the real image is rewritten.
|
||||
expect(out).toContain('```\n\n```')
|
||||
expect(out).toContain('/sidebar/file?')
|
||||
})
|
||||
|
||||
it('does not rewrite image-looking text inside inline code spans', () => {
|
||||
const md = 'Use `` syntax.\n'
|
||||
const out = rewriteLocalImageUrls(md, scope, '/repo/readme.md', ORIGIN)
|
||||
expect(out).toContain('``')
|
||||
expect(out).toContain('/sidebar/file?')
|
||||
})
|
||||
|
||||
it('does not rewrite a reference definition used only by a plain link', () => {
|
||||
// The `[manual][docs]` link references `[docs]: ./docs.md`, but that
|
||||
// definition must NOT be redirected to /sidebar/file because it is not
|
||||
// referenced by any image. Only image-referenced definitions are rewritten.
|
||||
const md = '[manual][docs]\n\n![pic][pic-def]\n\n[docs]: ./docs.md\n[pic-def]: ./pic.png'
|
||||
const out = rewriteLocalImageUrls(md, scope, '/repo/readme.md', ORIGIN)
|
||||
expect(out).toContain('[docs]: ./docs.md')
|
||||
expect(out).not.toMatch(/\[docs\]:.*\/sidebar\/file/)
|
||||
// The image-referenced definition IS rewritten.
|
||||
expect(out).toMatch(/\[pic-def\]:.*\/sidebar\/file/)
|
||||
})
|
||||
})
|
||||
|
||||
Reference in New Issue
Block a user