perf: move the 19 non-zh/en dictionaries into a lazy locale chunk
The core client bundle statically imported every third-language dictionary (ja/de/fr/…/zh-HK/MO/TW, ~640KB of source — roughly half the bundle's weight) for a code path most sessions never enter: the sidebar's own t() only consults zh/en plus the better-locale override store, and the dicts' ONLY consumer is that store's register() call. They now ride the existing lazy-chunk machinery as lib/client-locale.js (fetched from /sidebar/bundle only when better-locale is actually installed; a generation counter keeps the async registration moot when the integration effect re-runs or disposes mid-flight). Until the chunk lands, t() keeps the zh/en chain; the store's own revision bump on register re-renders the chrome once the dicts arrive. Core client.js: 1.46MB → 822KB (-44%). The chunk-boundary key-set check moves to the existing runtime test (every shipped dict stays key-set-equal to zh).
This commit is contained in:
1 parent
b7af498427
commit
c7d58c9b25
8 files changed
+100
-69
No files matched your search
+19
-8
@@ -24,10 +24,8 @@ import { registerSettingsNavIcon } from './settings-nav-icon.ts'
|
||||
import { loadBootDecision } from './prefs.ts'
|
||||
import { SideCardSection } from './SideCardSection.tsx'
|
||||
import { api } from './api.ts'
|
||||
import { LOCALE_NS, attachLocale, attachBetterLocale, t, zh, en,
|
||||
ja, de, fr, pt, ko, ar, hi, id, tr, vi, th, ru, it, nl, sv, pl,
|
||||
zhHK, zhTW, zhMO,
|
||||
} from './locales.ts'
|
||||
import { LOCALE_NS, attachLocale, attachBetterLocale, t, zh, en } from './locales.ts'
|
||||
import { loadChunk } from './chunk-loader.ts'
|
||||
import css from './sidebar.module.css'
|
||||
import './layout.css'
|
||||
|
||||
@@ -82,7 +80,12 @@ export function apply(ctx: Context): void {
|
||||
// the ja dict once the store becomes available.
|
||||
ctx.effect(() => {
|
||||
let dispose: (() => void) | undefined
|
||||
// Guards the async chunk registration below: a sync() re-run (or fiber
|
||||
// disposal) that lands while the chunk is still in flight must render
|
||||
// that registration moot.
|
||||
let generation = 0
|
||||
const sync = (): void => {
|
||||
generation += 1
|
||||
dispose?.()
|
||||
dispose = undefined
|
||||
const store = ctx.get('betterLocale') as
|
||||
@@ -96,10 +99,17 @@ export function apply(ctx: Context): void {
|
||||
| undefined
|
||||
attachBetterLocale(store)
|
||||
if (store !== undefined) {
|
||||
dispose = store.register(LOCALE_NS, {
|
||||
ja, de, fr, pt, ko, ar, hi, id, tr, vi, th, ru, it, nl, sv, pl,
|
||||
'zh-HK': zhHK, 'zh-TW': zhTW, 'zh-MO': zhMO,
|
||||
})
|
||||
// The 19 override dictionaries ride the lazy `locale` chunk: until
|
||||
// it lands, the store has no betterSidebar entries and t() keeps
|
||||
// the zh/en chain; the store's own revision bump on register
|
||||
// re-renders the chrome once the dicts arrive.
|
||||
const myGeneration = generation
|
||||
void loadChunk('locale')
|
||||
.then(mod => {
|
||||
if (myGeneration !== generation) return
|
||||
dispose = store.register(LOCALE_NS, mod.localeDicts as Record<string, Record<string, string>>)
|
||||
})
|
||||
.catch(() => { /* the dicts stay unregistered; the zh/en chain runs */ })
|
||||
}
|
||||
}
|
||||
// Initial check (picks up the store if better-locale activated first).
|
||||
@@ -108,6 +118,7 @@ export function apply(ctx: Context): void {
|
||||
// activates with a persisted override, and when the user switches).
|
||||
const unsubscribe = ctx.locale.subscribe(sync)
|
||||
return () => {
|
||||
generation += 1
|
||||
unsubscribe()
|
||||
dispose?.()
|
||||
attachBetterLocale(undefined)
|
||||
|
||||
Reference in new issue
Block a user