Merge pull request #43 from ma15803216102/fix/html-preview-windows-drive-path

fix(html): Windows 盘符路径解码去掉前导斜杠,修复 html 预览被 isWithin 拒绝
This commit is contained in:
Atlas Zeng
2026-08-14 18:26:40 +08:00
committed by GitHub
2 changed files with 27 additions and 3 deletions
+17 -2
View File
@@ -6,6 +6,7 @@
* the session scope intact (the WHY of the path-encoding design).
*/
import { describe, expect, it } from 'vitest'
import { resolve } from 'node:path'
import { decodeHtmlUrl, encodeHtmlUrl } from '../src/html-route.ts'
describe('encodeHtmlUrl', () => {
@@ -38,11 +39,25 @@ describe('decodeHtmlUrl', () => {
})
})
it('decodes a Windows round-trip', () => {
it('decodes a Windows round-trip (drive path WITHOUT a leading slash, so node resolve() keeps the drive)', () => {
const url = encodeHtmlUrl('sess-1', 'C:\\Users\\me\\a.html')
expect(decodeHtmlUrl(url)).toEqual({
ok: true,
ref: { sessionId: 'sess-1', path: '/C:/Users/me/a.html' },
ref: { sessionId: 'sess-1', path: 'C:/Users/me/a.html' },
})
// The host runs requireAbsolute() over the decoded path: with the old
// '/C:/...' form node's resolve() produced 'C:\C:\Users\...' (drive
// doubled) on Windows and the isWithin(cwd) fence rejected every drive
// path. The slash-free form must resolve back to the original path.
if (process.platform === 'win32') {
expect(resolve('C:/Users/me/a.html')).toBe('C:\\Users\\me\\a.html')
}
})
it('decodes a lowercase-drive Windows path without a leading slash', () => {
expect(decodeHtmlUrl('/sidebar/html/s/d%3A/work/x.html')).toEqual({
ok: true,
ref: { sessionId: 's', path: 'd:/work/x.html' },
})
})