fix(subagent): emit an explicit mode=unknown so the aside open survives both gates
The `subagentchat` aside open failed silently: the host's `parseSubagentChatAddress`
(the tab type's `canOpen`) rejects a MISSING mode (`get("mode")` → `null`), so a mode
we could not stand behind — omitted to dodge the controller's 401 — made `claim` refuse
the address (`sidebarRight: tab type "subagentchat" refuses ...`), and the right column
never revealed.
Fix: the codec now normalizes an unknown/undefined mode to an EXPLICIT `mode=unknown`
instead of dropping it. That value passes both gates:
- client: `parseSubagentChatAddress` accepts `unknown` → `canOpen` true → claim accepts;
- server: `validateAddress` skips the compare when `mode === "unknown"` → no 401.
A real (one-shot/continuable) mode is still emitted when the host catalog is `ready` and
has the child; only an honest `unknown` is sent when it is not.
Drops the TEMP `diag.append` probe route + the client before/after diag fetches (their
mission is done) and rewrites the two spec cases to assert the explicit `mode=unknown`.
Verified with the host's real `parseSubagentChatAddress` pulled verbatim from the app
bundle: the old no-mode address → canOpen false (reproduces the refuse), the new
`mode=unknown` address → canOpen true. typecheck / lint / 29 subagent+sidechat specs green.
This commit is contained in:
@@ -50,18 +50,18 @@ describe('subagentChatAddress', () => {
|
||||
expect(SUBAGENT_CHAT_KIND).toBe('subagentchat')
|
||||
})
|
||||
|
||||
it('omits an unknown mode so the host treats it as "unknown" and skips the check', () => {
|
||||
// The degraded synthesized catalog guesses mode from `running`; a wrong
|
||||
// guess used to 401 the open (the controller compares address.mode against
|
||||
// the child's durable descriptor). An unrecognized mode must be dropped,
|
||||
// which the controller reads as `mode: "unknown"` and does not compare.
|
||||
it('normalizes an unknown mode to an EXPLICIT mode=unknown (never omitted)', () => {
|
||||
// `parseSubagentChatAddress` (the native tab type's `canOpen`) rejects a
|
||||
// missing mode (`null`), so an unrecognized/unknown mode must be EMITTED as
|
||||
// the literal `mode=unknown` — which both the client parser accepts and the
|
||||
// controller skips (`mode !== "unknown"` is false). Omitting it used to make
|
||||
// `claim` refuse the address.
|
||||
const address = subagentChatAddress({
|
||||
parentSessionId: 'p',
|
||||
childSessionId: 'c',
|
||||
mode: 'unknown' as never,
|
||||
})
|
||||
expect(address).toBe('dsh-resource://subagentchat/session/c?parent=p')
|
||||
expect(address).not.toContain('mode=')
|
||||
expect(address).toBe('dsh-resource://subagentchat/session/c?parent=p&mode=unknown')
|
||||
})
|
||||
|
||||
it('still emits the mode when it is one of the two durable values', () => {
|
||||
@@ -70,4 +70,14 @@ describe('subagentChatAddress', () => {
|
||||
expect(subagentChatAddress({ parentSessionId: 'p', childSessionId: 'c', mode: 'continuable' }))
|
||||
.toContain('mode=continuable')
|
||||
})
|
||||
|
||||
it('normalizes an unknown (undefined) mode to an explicit mode=unknown', () => {
|
||||
// The degraded path: the host catalog never hydrated, so the caller has no
|
||||
// durable mode — it passes `mode: undefined`. The codec must NOT omit it
|
||||
// (a missing mode is `null` and the host's `canOpen` refuses the address);
|
||||
// it emits an explicit `mode=unknown`, which the controller skips
|
||||
// (`mode !== "unknown"` is false) so the open never 401s.
|
||||
const address = subagentChatAddress({ parentSessionId: 'p', childSessionId: 'c', mode: undefined })
|
||||
expect(address).toBe('dsh-resource://subagentchat/session/c?parent=p&mode=unknown')
|
||||
})
|
||||
})
|
||||
|
||||
Reference in New Issue
Block a user