98a446bbfcf7988d9feb2c9144a29d61193d8ca1
23
Commits
| Author | SHA1 | Message | Date | |
|---|---|---|---|---|
 Menghuan1918
|
98a446bbfc |
fix(sidebar): 点击展开时文件树整体重建（两处根因）+ v0.24.1
用户报告：「点击展开的时候，文件树会频繁整体刷新，看起来非常难受」。
根因 1（主）：src/client/native/index.ts 的 sync() 把 files 接管项当成多余注册。
它按 KIND 记账、永远不在 wanted 里，于是每次 sync 都被 dispose + 重建；而
disposeSubscriptions 同时订阅了 service 与 store，**任何会话状态写入**（展开/收起、
切 tab、拖底部工作台、选中…）都会跑一遍 sync。替换 slot 注册 = 宿主换 slot entry →
插件 tab body 被 unmount/remount → 文件树丢失层缓存、滚动位置与目录 watcher，并重新
fs.trees([root, ...expanded]) 重列整棵可见树。机械证明（临时插桩，已回退）：
[probe-sync] enter live=[editor,git,subagent,sidechat,diff,files]
[probe-registerSlots] slot inject ran for dsh-better-sidebar:files
[probe-body] unmount tab3 kind=files
[probe-body] mount tab3 kind=files
修法：wantsFiles 提前，删除循环里对 files 接管项 skip（禁用 editor 时仍照旧释放）。
根因 2（次）：FileTree.tsx 的 retryDir 先把该层缓存删掉再请求，行被「Loading…」
占位替换后重建——目录有外部写入（构建 / 格式化 / 模型跑 bash）时整层闪空。
修法：复用既有 force 路径 loadLevels([dir], { force: true })，保留旧行直到新答案到达
（与 refreshTick 的强制刷新路径行为一致）。
判别性证据（回退任一修复即红）
- tests/native-surface.spec.ts：三次 store 写入不得产生任何注册/注销 → 回退后
registered 6 → 12、disposed 全是 dsh-better-sidebar:files
- tests/file-tree-batch-load.spec.tsx：重列期间旧行仍在屏 → 回退后层被删空
- 新增真实宿主 lane tests/e2e/zz-expand-refresh.e2e.ts（quiescence 判据，无固定 sleep；
zz- 前缀保证它最后跑，因为它会自建 workspace + session）：A1 展开只请求被展开那一层、
A2 tab body 存活（不重开 watch socket）、A3 屏上行数不归零；回退修复 1 后退出码 1
（Error: expanding a folder must ask for that folder, not the whole visible set）
修复后实测（40 子项目录，同一探针/机器/工作区）
| 阶段 | fs.trees payload | 新开 ws | DOM +/- | 被删行 | body 替换 | 层内最小行数 |
| 展开 big | [big]（原 [root, big]） | 0（原 1） | +41/-1 | 0（原 45） | 0（原是） | 40（原 40） |
| 外部写入 big | [big] | 0 | +1/-0（原 +41/-40） | 0 | 0 | 40（原 0） |
| 展开 bravo | [bravo] | 0 | +2/-1 | 0（原 45） | 0（原是） | 41 |
证伪记录：新建 fs.watch(dir,{persistent:false}) 在 macOS 上无改动时 0 事件（Node 微
探针两遍 + 8 轮真实时序 + 浏览器侧从未收到 {dir} 陈旧帧）→ src/fs-watch.ts 与
use-dir-watch.ts 一行未改。
验证：pnpm typecheck / lint / test（136 文件 1486 通过 9 跳过，基线 1484 + 新增 2）/ build
全绿；DSH_CMD='npx -y --package @deepseek-ai/dsh@0.2.0-rc.1 dsh' pnpm test:mount = 8/8。
版本 0.24.0 → 0.24.1（package.json / dsh.plugin.json / SIDEBAR_SERVICE_VERSION /
README×2 / CHANGELOG×2 同步）。
|
||
|
Menghuan1918
|
5c95002641 |
perf(sidebar): fs.tree 22.8ms→3.8ms + 删除工作区路径检测（放开权限）+ 树展开状态按会话
用户实测反馈：
1) `/sidebar/api/fs.tree` 性能极差 —— 先测后改（10k 条目目录、热缓存、中位数）：
- 冷调用 cap=1000：22.76ms → **3.77ms**；TTL 内重复：≈23ms → **0.000ms**
- 改法：opendir for-await → readdir(withFileTypes) 一次取回；只为 cap 条建行
（slice + 定长数组）；路径用字符串拼接而非 path.join；排序弃 localeCompare
（14.6ms/10k → 0.35ms）改小写比较 + 原名码点兜底；新增 1.5s 目录级缓存
（键 绝对路径\0cap，上限 512），由 fs.write/rename/remove/mkdir/upload 与
fs-watch 的变更通知显式失效
- 契约逐字不变；新增 tests/fs-tree.spec.ts 6 例 + fs-watch 失效用例（判别性验证）
2) 删除工作区路径检测（默认不检测、放开权限）：
- path-security 变纯词法解析（realpath/包含性判定删除）、fs-operations 去 fence
分支、所有 fs 路由不再读 fence、403 分支消失、config 删 workspaceFence 字段
（schemastery 容忍未知键，旧 profile 不会加载失败）、settings 开关删除
- ⚠️ 安全影响：插件 fs 路由（tree/read/write/rename/remove/mkdir/媒体/HTML/
upload/archive）现在可读写宿主用户可访问的任意路径，只受 OS 权限约束；
指南 §8.1 已加醒目声明
- 死代码清理：FenceErrorNotice 组件 + EditorHost 分支 + 4 个词条（settingsFence*、
fenceErrorReason、fenceDisableAction）+ isOutsideWorkspace* 助手 + TreePanel 的
store prop + 相关 CSS 块
3) 批量列举路由 `fs.trees`（单层失败只在该层带 error）+ 客户端批量加载：
挂载/刷新时的 N+1 请求变为 1 个（8 个展开目录：9 → 1，探针断言）
refreshTick 不再先清缓存（旧行保留到新答案；失败保留旧行 + warn 提示）
4) 修复「关闭文件后返回文件树，展开状态被重置」：
原生承载面的展开集合原来存在每个 tab 的记录里（drop 即丢），改为**每会话状态**
的投影（ensure 从会话态读、toggleExpanded 写回会话态、registerNativeSurface 用
attachStore 订阅）；同一会话多 tab 共享、不同会话隔离；revealed 保持 per-tab
验证：typecheck / lint / test（136 文件 / 1484 通过 / 9 跳过）/ build 全绿；
DSH_CMD='npx -y --package @deepseek-ai/dsh@0.1.7-rc.1 dsh' pnpm test:mount 7/7 通过；
版本镜像同步（dsh.plugin.json + SIDEBAR_SERVICE_VERSION）
|
||
|
Menghuan1918
|
ee1fe05067 |
feat(sidebar): 菜单层级/性能 + 选中条吸底 + 打包进度 + 修复「在侧边打开」
用户实测反馈 5 条：
1) 文件列表性能 / 右键菜单不再刷屏（先测量后改，探针 tests/file-tree-menu-perf.spec.tsx）
- 宿主应用列表按路径缓存：N 次打开菜单只请求 1 次（原每次 1 次 + Loading 帧）
- 行上的 git 数据改为原始值（tone/letter）：共享 store 每次轮询重建对象不再触达行
（探针：开窗 folderIcons 4 → 0；root 行也 memo 化）
- 菜单开关不触发目录重列（fsTree=0）；实测「菜单打开期间暂停轮询」会让变更行瞬时
掉色并多两次重渲染，故按测量结果放弃该做法（数字与理由写进探针注释）
2) 「已选择 N 项」条移到底部：滚动容器最后一个内容子节点 + sticky bottom（不遮最后
一行），窄栏 flex-wrap 换行不出横向滚动条
3) 菜单层级重构：一级只留默认动作（宿主默认应用 / 打开方式 ▸ / 在文件管理器中显示 /
新 Tab / 在侧边打开 / 下载 / 压缩并下载 / 复制路径 / 重命名 / 删除；目录行另有
新建文件夹、上传到此处），应用列表整体收进「打开方式」子菜单；宿主探测到本机关联
应用时默认不显示插件自研 open-with 项目，新增设置开关 openWithPluginTargets
（editor descriptor 的 pluginToggles）可强制并存；宿主不可用时插件项目照旧
4) 压缩并下载显示进度：宿主改为可观测任务（archive.build / archive.status /
/sidebar/archive?id=，4 并发 + 5 分钟 TTL + sessionId 绑定，buildZip 逐条目
onProgress），客户端轮询 250ms 显示「正在打包 done/total · N%」，ready 后 blob 下载，
失败进 zipFailed
5) 修复「在侧边打开没有效果」：根因是它只写插件底部工作台（原生右侧栏的 tab 不在
bottomSplits 里），现按承载面分流 —— 原生 tab 走 service.openTab(target:'side') →
宿主 openResource(preferNewPane, revealIfOpened:false) 真正分栏；底部工作台行为不变
（接入 API 变更已同步 docs/external-plugin-guide.md）
验证：typecheck / lint / test（135 文件 1461 通过）/ build 全绿；
DSH_CMD='npx -y --package @deepseek-ai/dsh@0.1.7-rc.1 dsh' pnpm test:mount 7/7 通过；
新增/更新测试：menu-perf(3)、archive(10)、open-in-app(18)、open-with(10)、multiselect(9)、
zip(37)、service(64)、editor-host(11)、builtins(23)、locales(20)
|
||
|
Menghuan1918
|
13d4bae321 |
fix(sidebar): 二轮独立验证的 9 项缺陷 + 目录级暂存
verifier 二轮报告（F1–F9）全部修复，每条都有「临时回退即变红」的判别性验证： - F1【高】中文等非 latin1 下载名 → 真实宿主 500：content-disposition 改用 RFC 5987（ASCII 回退 + filename*=UTF-8''）；补真 node:http 用例与根因对照断言 - F2【中】多选同名文件归档重名（解压互相覆盖）：冲突项逐级上溯父目录消歧 - F3【中低】maxBytes 在读完之后才判定；budget<=0 的 0 字节 FIFO 会永久阻塞： 改为先 stat、读取前拒绝（FIFO 探针验证） - F4【中低】SSH 模式 + 宿主不可用时 reveal 整条消失：保留 kind==='reveal' 目标 - F5【低】图钉嵌套交互语义非法且键盘不可达：改为诚实的鼠标热区，键盘入口归设置面板 - F6【低】变更树空闲 tick 全量重渲染：行 memo + 恒定 props + 内容键派生 + 共享 store 的 sameStatus 保住快照身份 - F7【低】排序随运行时 locale 漂移：显式 'en' collation + 码点兜底 - F8【低】POSIX 文件名的反斜杠被当成层级：不再替换 - F9【低】打包中重复点击静默、无反馈：busy 行（role=status）+ in-flight 守卫 - 新增：目录行「暂存/取消暂存该目录」（git pathspec 语义，不触发折叠） 验证：typecheck / lint / test（134 文件 1441 通过）/ build 全绿； DSH_CMD='npx -y --package @deepseek-ai/dsh@0.1.7-rc.1 dsh' pnpm test:mount 7/7 通过 |
||
|
Menghuan1918
|
b011be1e98 |
feat(sidebar): 打开方式双源并存 + 多选压缩下载 + 文件变动层级树
用户追加三条需求，全部落地： 1) 打开方式 = 宿主探测应用 + 插件自研 open-with（并存） - 逐字恢复 src/client/open-with.ts / open-with-settings.tsx / plugin-settings.ts / src/open-external.ts / open.external 路由 / api.openExternal / editor descriptor 的 settings.render，以及 20 个 openWith* 词条（19 份词典从 main 取回原文） - 恢复 menu-flip.ts + layout.css 子菜单翻转规则（子菜单回来了） - FileTree 菜单段（无标题行）：宿主行 → 分隔线 → 插件 pinned + 「在应用中打开 >」 子菜单（图钉 / SSH 后缀原样）→ 分隔线 → 宿主 reveal；宿主可用时过滤插件 explorer 目标，宿主不可用时插件行照旧（SSH 远端场景保持可用） - 死键清理：菜单去掉标题行后 openInApp 词条无引用，已从 21 份词典删除 2) 文件页多选右键「压缩并打包下载」 - 新增 src/zip.ts（自研 ZIP：方法 0/8 按收益二选一、UTF-8 bit 11、目录条目、 自实现 CRC32、无第三方依赖）+ src/archive-route.ts（名净化 + 递归收集）+ GET /sidebar/archive（同一道 workspace fence、目录递归跳过符号链接、 10000 条目 / 256 MiB 上限）+ api.archiveUrl - FileTree：多选 ≥2 项或单选目录时出现；fetch → blob → objectURL 下载， 路由错误（超限 / fence / 非 GET）以 zipFailed 显示在错误条 - 修掉真实缺陷：central directory 只写 MS-DOS 位而 version-made-by 声称 Unix， Info-ZIP 会把每个文件解成 mode 000；改为 Unix 语义（0o100644 * 0x10000， << 16 会溢出 int32）。系统 unzip 复验：mode 644/755、unzip -t 无错 3) 文件变动页层级树 + 视觉打磨 - 新增 src/client/changes/change-tree.ts：单子目录链压缩成一行、目录先于文件、 大小写不敏感排序、文件带 GitFileStatus、目录带下级变更数 - GitLens 两组各自渲染树：折叠状态按「组+路径」独立、默认展开；分组头吸顶 + 计数胶囊；Stage all/Unstage all 改为带 aria-label 的 IconButton；选中 = interactive-bg-active + 2px 内嵌强调条；12px/级缩进 + l1 参考线； 历史行 hash 徽标 / ref 胶囊 / 作者·时间右对齐 验证：typecheck / lint / test（134 文件 1422 通过）/ build 全绿； DSH_CMD='npx -y --package @deepseek-ai/dsh@0.1.7-rc.1 dsh' pnpm test:mount 7/7 通过； 真实宿主截图确认三条需求（多选+双源菜单+zip 项、变动页树形层级） |
||
|
Menghuan1918
|
36fbc5ac7e |
feat(sidebar): 文件页与文件变动页 UIUX 重构 + 全局组件抽取
文件页（FileTree/TreePanel）
- Ctrl/Cmd 多选 + Shift 按可见行序连选（Esc/点空白/右键收敛），批量条支持复制路径、批量删除（共享 ConfirmDialog + 顺序 fsRemove）
- Git 变更着色：行名按状态上色 + M/A/D/U 徽标，目录按 dirHasChanges 着色，非仓库静默降级（数据来自共享 git 状态存储）
- 新建文件夹：fs.mkdir 路由 + mkdirWorkspaceEntry + 内联输入行（Enter/Esc/blur/IME 守卫）
- 性能：FileRow/DirRow memo（含反向验证）、搜索 hidden 停车不再卸载树、level 拉取世代守卫 + AbortController、fs.tree truncated 提示、use-dir-watch 入参 memo
- 拖拽上传视觉 token 化（硬编码色清零）；可见性下传后隐藏页签停止轮询
- 右键「打开方式」改为复用 DSH 自带 open-in-app（宿主探测的关联应用 + 文件管理器显示）
文件变动页（changes/diff）
- 36px 头（宿主 SegmentedControl）+ 单一 ChangeRow + SectionHeader 分组 + 吸底提交条单状态行 + 历史独立空态
- 修掉：双份空态、暂存失败 unhandled rejection、手动刷新被丢、仓库切换刷新两次、worktree 清单缺 repoRoot、工作树被自动切走、预览持旧快照、恢复高度未 clamp、session ops 无谓轮询
- DiffPane/DiffTab 共用 use-git-diff；修掉 DiffPane 的 untracked 预览从不渲染
全局组件与宿主接入
- 新增 src/client/ui（IconButton/Chip/SectionHeader/Notice/ConfirmDialog/StatusBadge + 共享 git 状态存储）
- 新增 src/client/open-in-app.ts（宿主 open-in-app 客户端适配），删除自研 open-with 全链路与 open.external 路由
- 客户端 inject 补 remote / remote.session：缺声明时 ctx.get('remote').session 会抛出并把整个面板打成错误条（真实挂载 lane 抓到）
- 词典：+25 键 / -20 openWith* / -noChanges，20 份同步
验证：typecheck / lint / test（126 文件 1322 通过）/ build 全绿；
DSH_CMD='npx -y --package @deepseek-ai/dsh@0.1.7-rc.1 dsh' pnpm test:mount 7/7 通过（含 tab sweep 与 perf lane）
|
||
|
Menghuan1918
|
6586e3e2d3 |
feat: adapt to DSH 0.1.7-alpha.1 and yield the read-only previews
DSH 0.1.7-alpha.1 is 1299 commits past 0.1.6-alpha.2 and rewrites four
contracts this plugin was built on. The peer floor moves to
^0.1.7-alpha.1 (semver's prerelease rule means ^0.1.6-alpha.2 can never
match a 0.1.7 prerelease); 0.1.6-alpha.2 and earlier stay on v0.19.1.
Released as 0.21.0-alpha.1 (dist-tag alpha).
Hard breaks:
- dsh-settings was rewritten: register(ns, schema) is gone, a form is
addressed by the plugin row's Loader entry id and read from the
module's exported Config. The preferences are merged into Config and
marked volatile — which requires DSH's own schemastery, because only
that build wraps a volatile field in the cosmokit reference the
loader's volatile commit walks. With the public package a settings
write reports success and revision 1 while the effective value never
changes.
- ui-primitives renamed its whole icon family (IconXxx14/16 ->
IconXxxRegular/Medium): 26 imported symbols, 17 files. The failing
mode is render-time, not load-time. Five call sites that relied on the
old 14px default now pass size={14} explicitly.
- Session format v4 rejects source.kind === 'plugin'; the side-chat
boundary injection now writes plugin:dsh-better-sidebar, the same kind
DSH's own v3->v4 migration produces, so historical threads survive.
Tool results moved to role 'tool' with top-level content/isError; all
four parsers accept both shapes.
- The client session snapshot dropped subagentsByParent/jobsBySession
and the on-demand subagent-catalog observation API. The Tasks page
reads projectionsBySession and a new jobs.list route.
Yields and convergence:
- The read-only previews go to DSH's documentpreview (Office->PDF, a
spreadsheet worker, zoom, per-directory refresh); editor.canOpen
refuses those 26 extensions. Markdown, HTML (with its sandbox
switches) and the editable code buffer stay.
- The host browser kind is desktop-profile-only now, so the web e2e
lanes expect no browser entry and assert its absence.
- Link takeover claims only urlTarget links and passes the rest to the
host, fixing a regression from the 0.1.6 round: the fallback pointed
at a 'browser' type the plugin no longer registers, so http links in
its own markdown did nothing.
Also fixed, found along the way:
- The file tree refreshes live (new directory watch over the plugin's
own socket), since the plugin owns the `files` kind.
- ctx.sessions.list has no `current` field at either tag; the three
readers were dead. They now use ctx.sidebarRight.mounted.
- package.json.files was missing lib/client-locale.js.
- Two genuinely dead call sites: sessions.openSubagent/open/
refreshSubagents do not exist on the current baseline, so the
topology click, the jump-back and the retry were all no-ops.
- The test harness window shim lacked addEventListener, which the 0.1.7
primitives call at module-evaluation time; and the e2e token exchange
needs Playwright's request stack, not Node's fetch.
|
||
|
Menghuan1918
|
22e772ce45 |
feat(icons): file icons and tab glyphs in color, from the host's own artwork
Issue #611 asked for file-type icons like the official explorer's, and #429 built a colored theme for them. DSH 0.1.5-rc.2 makes most of that work unnecessary: `@deepseek-ai/dsh-client-ui-primitives` now exports `FileTypeIcon` / `CodeFileIcon` with the host's own 48-type full-color code artwork plus category-colored sheet glyphs (and its classifier behind them). So the plugin renders the host's icons instead of shipping a color table, and color becomes the only behaviour rather than an opt-in theme. File icons (src/client/file-icons.tsx) - `builtinFileIcon(path, size)` → `<FileTypeIcon path size />`; folders use the host's folder category. The plugin's own per-extension VSCodicon map is gone. - The public `registerFileIcon` API from #531 is unchanged and still outranks the built-ins, so an external plugin can take over any row. One semantic consequence, now documented and tested: because the host classifier covers every path, a registered catch-all (`exts: []`) claims rows it used to lose to the built-in map. An unregistered catch-all (the old icon theme's shape) is unaffected. - Nothing is lazy any more: the artwork lives in a platform module the client already holds, so `lib/client-file-icons.js` and its 563-entry dataset (255 kB) are deleted outright — the core bundle grew by 10 kB (0.85 → 0.86 MB). - `src/client/file-icon-theme.ts`, the `fileIconTheme` pref (prefs-shared / config / client prefs), the settings-page select row and the six `settingsFileIconTheme*` keys in all 20 dictionaries are removed with it. Tab glyphs (src/client/builtins/tab-icons.tsx) - Every built-in tab type now declares a colored glyph: files (the host's folder artwork), changes/diff (commit), tasks (checklist), side chat (discussion), terminal (shell), browser (globe). - The color comes from a `--dsw-alias-*` token through a wrapper class, never from a literal — the skin contract (§12) holds and `tests/theme.spec.ts` enforces both halves (no literals in the module, every color declaration in the stylesheet resolves to a token). Native right Sidebar chips (src/client/native/tab-adapter.tsx) - The host's tab definition has no icon field, but the `sidebar.right.pane.tab.title` slot IS the chip's content, so the plugin draws the glyph itself: an editor tab with a path shows that file's icon, every other tab shows its descriptor's icon — the same `descriptor.icon` the workbench strip and the guide capsules already render, so the three cannot drift. The glyph is `aria-hidden`, which keeps the chip's accessible name exactly the title the mount lane matches on. Gates: typecheck / lint / check:consumer-types green; pnpm test 127 files / 1342 passed / 9 skipped (3 new chip cases, 1 rewritten built-in case). |
||
|
Menghuan1918
|
8722bfb29c |
fix(file-icons): 适配 v0.18.1 基线——重命名行接入解析器 + 测试与门禁补齐
rebase 到 main（v0.18.1）后的适配层： - 冲突（EditorHost ×2 / TreePanel / FileTree）按并集解：main 侧 onPathRenamed/onPathDeleted 与 PR 侧 service prop 并存。 - main 新增的行内重命名行仍用 <VscFile>/<VscFolder>，而本次改动已删除 VscFile import（合并后 TS2304）——改走 dirRowIcon/fileRowIcon，与树行 同一条回退链；VscFolder 随之无引用，从 import 移除。 - tests/file-icons.spec.tsx：markerB 换成独立元素类型（<b>），使 「priority 降序 / 同级按注册序」断言真正可区分（此前两个 marker 都是 <span>，断言恒真）；新增「工厂返回 undefined 则拒绝该级、链继续」与 「注册/注销触发订阅通知」两例（17 → 19）。 - tests/consumer-types.ts：补齐 FileIconDescriptor / registerFileIcon / getFileIcons / matchFileIcon / matchFolderIcon / fileIcon / folderIcon / FOLDER_EXT / FOLDER_OPEN_EXT 的编译期门禁。 - README：v0.19.0（未发布）段移到「最近更新」最前（此前被自动合并夹在 v0.18.1 与 v0.18.0 之间）。 - file-icons.tsx：注释修正——展平后的 Map 是后写覆盖，不是「first match wins」；当前无重复扩展名键，仅潜在语义。 |
||
|
Menghuan1918
|
8025b83a45 |
feat(file-icons): 目录保留扩展名注册 + 全局默认兜底 + 编辑器文件 tab 对应
- registerFileIcon 保留 'folder'/'folder-open' 特殊扩展名：目录行（含根行） 图标可注册，匹配保留值不认领真实 .folder 文件 - 新增权威解析器 fileIcon(path,size)（具体注册 → 内置 glyph → catch-all 全局默认 → VscFile，逐工厂崩溃隔离）与 folderIcon(path,open,size)； matchFileIcon 收窄为仅具体扩展名匹配 - 编辑器文件 tab（非 meta.dir）与文件树行显示同一 fileIcon 图标 - 同步 external-plugin-guide §7（保留值/回退链/三例注册）与 README （功能一览、v0.19.0-alpha.0 发布注记、服务化扩展章节） - tests/file-icons.spec.tsx 重写为 17 用例（链序/保留值/目录/崩溃回退） |
||
|
Menghuan1918
|
05773e0f2a |
feat(file-icons): 文件树按扩展名区分图标 + 对外 registerFileIcon API
- 新增内置扩展名→glyph 映射（md/媒体/pdf/json/代码/配置/数据库/压缩包， 单色 currentColor 遵循皮肤契约，未知扩展回退 VscFile） - ctx.betterSidebar 新增 registerFileIcon/getFileIcons/matchFileIcon （priority 降序，同优先级 catch-all 垫底），features 增加 'fileIcons' - FileTree 文件行消费注册表：注册图标优先（可为彩色 ReactNode， 工厂抛错回退内置），注册/注销即时生效 - 同步 docs/external-plugin-guide.md §7 与 tests/file-icons.spec.ts |
||
|
Menghuan1918
|
e39ea92ade |
feat(files): tree rename (inline) + delete (confirmed) + submenu visual tether
资源管理器补全：文件树右键菜单新增「重命名」（行内编辑：预填+全选、 Enter/失焦提交、Esc 取消、IME 组合键守卫）与「删除」（Modal 确认，文件/ 目录文案区分，永久删除——宿主无回收站）。根行（工作区根）不提供两项， 服务端 fs.rename/fs.remove 双保险拒绝；目标已存在 409；link-aware—— symlink 行只改/删链接本身（lstat 判定），fence 校验对解析后目标进行。 落定收尾：pruneTree 清旧前缀缓存 + 收起 stale expanded + 单层重载父目录； tab 调解走 service（rename→updateTab 改路径改标题、delete→closeTab 关 受影响 tab，覆盖两侧分栏/底栏/浮动窗口，经 tree-mutations.ts）。 二级菜单视觉关系（layout.css，仍限 data-dsh-sidebar-submenu 作用域）： 父行在子菜单打开期间保持高亮（宿主已渲染 aria-expanded="true"）， 卡片间距 10px→4px（悬停走廊同步收窄），翻转规则一并 4px。 i18n 新增 7 key × 20 语言文件（locales.spec 的 key-set-parity 门禁）。 测试：fs-operations 追加 12 例（rename/remove 全失败面）；新增 file-tree-rename-delete.spec.tsx 8 例（菜单可见性/重命名流/删除流/错误条）； menu-flip.spec.tsx 契约扩展覆盖 tether 规则。设计文档 docs/plans/2026-09-04-file-tree-rename-delete-design.md。 |
||
|
Menghuan1918
|
76b57508f4 |
fix(ui): compact context menus + viewport-clamped submenu flip
减重：全部右键菜单（FileTree 行菜单 / TabBar tab 菜单 / GitLens 文件与 历史菜单 / FreeWindow 标题菜单）与「+」菜单切到宿主 Menu 原语的 compact 密度（26px 行高 / 12px 字 / 164px 卡片），图标随槽位 16→14，「打开方式」 子菜单图钉 20→16，还原工具型右键菜单的趁手感。 越界：宿主子菜单纯 CSS 定位（从父行向上、向右生长）不受视口钳制——树顶 部右键时「打开方式 ▸」子菜单伸出视口上沿，窄面板（280–400px）时伸出右 沿。新增 menu-flip.ts：菜单打开期间在 <body> 发布 data-dsh-sidebar-submenu ="down|left" 方向 token（y < vh/2 → down；x + 400 > vw → left），layout.css 据此翻转子菜单生长方向与 ::before 悬停桥；属性存续期即作用域，宿主自有 菜单不受影响。刻意不做 max-height 滚动钳制——overflow 裁剪会切断悬停桥。 测试：menu-flip.spec.tsx（token 纯函数 + hook 生命周期 + CSS 契约跨文件 一致性）；tab-bar / file-tree 两个 spec 追加翻转向量断言；mount.e2e 追加 compact 行高（≤30px）布局级证据。设计偏差记录同步至 docs/plans/2026-08-22-open-with-menu-design.md。 |
||
|
Ch3n4y
|
94ffac0224 |
fix(editor): keep file basename in @-reference links
The explorer @ button appended plain text (@folder/file.ts), which DSH's composer only decorates as a folder ref (@folder/) — the file name stayed outside the link. Insert FILE references through DSH's own structured insert-reference event instead, minting one chip for the whole reference (displayed as @basename, serialized as the full @path). Directories keep the plain @dir/ mention so folder completion still works. |
||
|
Menghuan1918
|
b7af498427 |
perf: stabilize renders (transcript row reuse, tree Sets, shared + options, batched drags)
SideChat transcript: every 2s poll rebuilt ALL row objects, so every row (markdown parse + DOMPurify included) re-rendered even when the log had not changed. transcriptRows now takes the previous poll's rows and re-adopts the position-aligned rows whose content is identical (reuseRows) — only the changed tail rebuilds. The view feeds the memoized array back through a ref; unit tests pin the identity contract (unchanged rows keep object identity, changed rows and everything past the change rebuild, tool-result landings never re-adopt). FileTree: expanded/revealed membership was an includes() scan per rendered row (O(rows × expanded) per render on deep trees); one Set per render keeps it O(1) per row. Shell: buildNewTabOptions was inlined in the two Workbench JSX sites — two fresh arrays per render (drag state, resizes) re-rendered every LeafView's + affordance. One shared memo now. DiffPane resize / TerminalView ResizeObserver: pointer and resize streams fired a setState / glyph-measuring fit() per event; both ride per-frame batching now (frame-batcher in the core, a local rAF gate in the lazy terminal chunk). SessionLens sizes each row's content with a Blob (a UTF-8 encode of the whole edit) — that moved from per-row-per-render into one memoized pass per changed fold. |
||
|
Menghuan1918
|
a9353ce627 |
feat: workspace fence toggle (workspaceFence pref + one-click off in error surfaces)
- New persisted built-in pref workspaceFence (default true) under the files card's secondary settings modal; host reads it per request via the settings seam (fenceEnabledOf — absent/malformed stays ON). - ensureWorkspacePath/ensureWorkspaceWritePath gain a fence param: disarmed skips the containment assert but keeps realpath resolution; wired through fs.tree/fs.read/fs.write, the media + html routes, and the upload path (writeWorkspaceUpload fence input). - Editor load failures and file-tree level errors show the localized reason plus a one-click global off (FenceErrorNotice) that flips the pref, adopts it into the store, and auto-retries the failed operation (reloadSeq / retryDir) — the raw wire text is never shown. - GitView's two client-side pre-checks (hidden open action + no-op defense) respect the pref; store threaded through TreePanel/FileTree. - i18n: 4 new keys across all 21 dictionaries; tests: fence-off route coverage, prefs parsing, schema default, editor toggles list; docs: guide §8/§8.1 + plans/2026-08-29 design record. |
||
|
Menghuan1918
|
052edb7685 |
fix: scope the "Show in folder" reveal scroll to the tree body
A reveal on a deep tree shifted the whole panel (tab bar included) out of the viewport: the reveal used native scrollIntoView, which scrolls every scrollable ancestor, and the fixed panel host ([data-dsh-panel-host], overflow hidden) is still a programmatically scrollable container — the host scrolled instead of (or besides) the tree, with no way to scroll back. Reported on DSH 0.1.2-alpha.1. Two layers: - FileTree: compute the centered, clamped target and scrollTo the tree body only; scrollIntoView is never called. - panel host: overflow hidden -> clip. A hidden box remains programmatically scrollable; clip keeps the same viewport-edge clipping (collapsed panels sliding off-screen) while making the host impossible to scroll, killing the whole leak class (md-toc jumps, future consumer scrollIntoView calls). |
||
|
HuanLinOTO
|
699ce448a1 |
fix: 处理 Copilot 二轮 review 的 10 条评论
- BrowserView: 即使 host 在白名单，GUI 自身 origin 永不给 allow-same-origin（裸 host 条目覆盖所有端口时可提权） - intercept: revealInExplorer 相对路径经 resolveSidebarPath 解析后再 revealPaths（交付物路径是相对的） - intercept: ctx.betterSidebar 改为 ctx.get（#357 纤维链读取约定） - FileTree/EditorHost/TreePanel/tabs: 把 revealed 贯通到树行渲染 + 高亮类 + scrollIntoView（此前高亮永不渲染） - state.revealPaths: 重建祖先目录时保留前导分隔符（POSIX/UNC 此前目录永远折叠） - state.schedulePersist: 仅活动会话写入全局宽度（targeted open 不再用非活动会话的过期宽度覆盖拖拽值） - browser.probe: GET 回退显式取消 body（否则流式/大响应挂住 socket） - terminal-font: leading generic 前只放 symbols-only 字体；fully-patched 放 generic 后（避免 hijack 度量字体） - sidebar.module.css: 恢复拖拽反馈（#130 的 silent resize 与 PR 描述冲突，取 HEAD） - Sidebar: 剩余 4 处 ctx.betterSidebar 改 ctx.get - tests: 补 revealPaths/iframeSandboxFor/terminal-font 回归测试 + EditorHost/FileTree 测试补 revealed prop |
||
|
Atlas Zeng
|
22a5d372be |
feat(editor): 文件树「在应用中打开」子菜单（外部编辑器/图钉固定/SSH 远端/自定义编辑器） (#334)
* feat(editor): file tree 'open with' submenu (external editors, pin, SSH-remote, custom editors) The file tree right-click menu gains an 'Open with >' submenu with the resource manager (reveal in file manager), VS Code, Cursor and Zed, plus user-defined custom editors (name + URL template + VSCode-family flag). Each submenu row carries a pushpin that promotes the target to a direct top-level menu item. A configurable SSH host (settings: Files card gear) switches VSCode-family openers to <scheme>://vscode-remote/ssh-remote+<host>/<path> and hides host-local targets (file manager / Zed / non-VSCode custom editors). External opens run through the new fenced /sidebar/api/open.external route which spawns the platform opener with an argv array (no shell); the client never navigates raw scheme URLs itself. The settings seam's render panel now appends after the declarative rows instead of replacing them. * feat(editor): polish open-with menu UI — brand icons, pushpin, chevron, row alignment - Submenu rows: the custom label is now a block-level flex row filling the primitives itemLabel, so the pushpin docks at the row's far right (matching the trailing check of every other menu); menu row icons normalized to 16px (DSH native menus use 16, ours were 14). - The submenu parent row gains a right-aligned chevron (the primitives Menu renders no arrow for submenu parents). - Icons via react-icons: codicons VscPin/VscPinned pushpins (replacing the hand-drawn pin), VscFile/VscFolder/VscFolderOpened tree glyphs (replacing the </> file mark), VscLinkExternal for the open-with parent and the browser tab's open-external button (globally), SiCursor/SiZedindustries brand silhouettes; the VS Code mark is inlined from simple-icons@11.0.0 (CC0) as IconVscode16 since later simple-icons releases dropped it. All monochrome currentColor to follow the active skin. - tsdown: pin react-icons si/vsc to their ESM entries via resolve.alias — the package's exports map lists require before import, so the shared conditionNames picked the unshakeable CJS entry and bloated the core bundle by ~6.4 MB; tree-shaken it now adds only ~12 KB. |
||
|
Atlas Zeng
|
9a40164d1a |
fix(explorer): 非文件拖拽不再触发文件树上传遮罩 (#317)
拖动 Tab（重排/跨 pane split）经过资源管理器文件树时，FileTree 的 dragenter/dragover/drop 此前对任何拖拽都响应：显示上传遮罩并吞掉 事件，导致 pane 根的 Tab-drop 处理收不到、Tab 无法落下。 统一按 dataTransfer.types 含 'Files' 门控（与 Sidebar.tsx 面板宿主 shield 一致）：非文件拖拽原样冒泡给 pane 根，OS 文件拖拽行为不变。 回归测试：应用内 Tab 拖拽不出现 uploadDropZone、不改 dropTarget、 不 preventDefault、不触发 onUploadRequest。 |
||
|
Atlas Zeng
|
4e52923970 |
refine(explorer): redraw the drop overlay illustrations (#281)
The first pass read poorly: the upload art was an arrow descending into a solid slab (a bathtub, not a tray) and the chat art's back card was a bare cyan blob. The upload zone now shows the classic notched tray with an arrow rising out of it — the same glyph family as the toolbar's upload icon — with all four corners rounded; the chat zone's two tilted photo cards each carry their own sun-over-mountains motif, tilts pivot around the card centers, and the front card gets a bolder mountain range. Both were iterated against rendered screenshots (light + dark mask) rather than by eyeballing path math. |
||
|
|
bb2456bea9 |
feat(explorer): upload files into the workspace from the file tree (#239)
* feat(explorer): upload files into the workspace from the file tree
- TreePanel header: upload-files / upload-folder buttons (folder picker keeps
the tree via webkitdirectory), with a one-line progress/result hint
- FileTree: drop files/folders onto the tree body (workspace root) or onto a
directory row (that directory); directory context menu gains 上传到此处
- api.ts: uploadFile posts base64 to /sidebar/upload (host writes it through
fs + shell decode; route provided for now by the local demo plugin)
- upload.ts: bytes->base64 (global-btoa-independent), FileList/DataTransfer
collection, sequential upload with per-file results; ~48MB per-file cap
- locales: zh/en strings; icons: IconUploadOutline16
* fix(explorer): reload tree after upload and auto-dismiss the status hint
The drop/context-menu upload path cleared the level cache but never
refetched (the refreshTick bump belongs to the button path), so the
visible tree emptied and only the persistent '已上传 N 个文件' hint
remained — the tree only came back after reopening the tab.
- FileTree.uploadInto now reloads root + expanded levels after clearing,
matching the refresh-tick path
- success status auto-dismisses after 3.5s (failures persist until the
next action) in both TreePanel and FileTree
* feat(host): add the /sidebar/upload route (raw bytes, workspace-safe)
The file tree's upload UI needs a host route; until now it pointed at a
locally-injected demo route. This is the real implementation:
- src/index.ts: register POST /sidebar/upload (exact route, same fence and
session-cwd resolution as every /sidebar route). Query params sessionId,
dir, relativePath; the raw request body is streamed into the workspace.
- src/fs-operations.ts: writeWorkspaceUpload streams chunks to a temp
sibling and renames into place, so a failed or oversized upload never
leaves a partial file. Upload dir must sit inside the session cwd, the
relativePath is sanitized (no '.', '..', empty or absolute segments) and
the target must stay inside both.
- src/config.ts: uploadLimit (default 128MiB; oversized -> 413 too-large,
a new wire code in src/wire.ts).
- client: send the File straight into the POST body (no base64 inflation)
and cap at the same 128MiB (upload.ts, api.ts).
Tests: tests/fs-operations.spec.ts covers write, nested dirs, traversal /
containment refusal, the size cap, and no-partial-file on failure.
(pnpm test: only pre-existing node-pty/git sandbox failures, identical on
clean main; typecheck and build pass.)
* fix(host): harden upload containment, temp-file atomicity and stream failure cleanup
- relativePath: absolute paths and empty segments are refused (400), not
silently collapsed or re-anchored (the spec's 'reject' semantics)
- temp file: uniquely named per request (randomUUID) so concurrent uploads
to the same target stay independent; crashed-process leftovers never
block later uploads (no pid reuse)
- write stream: permanent 'error' listener + error checks after every await
so a failing disk rejects the operation instead of crashing the host or
hanging the drain wait; the temp file is removed after the stream fully
closes (Windows file locks), never leaving a partial file
- docstring now states the containment is lexical (symlink trust model)
* fix(explorer): thread upload error codes and cancellation through the client
- api.uploadFile/fetchUpload accept an AbortSignal (long-op convention);
an aborted request rejects with the DOMException as-is instead of being
wrapped into a 'network' error
- UploadResult carries the wire error code; the client pre-check now emits
the same 'too-large' code as the host, and summarizeResults localizes
'too-large' instead of showing the raw English 413 message
- uploadToDir stops the queue on abort: completed files stay, in-flight
request is cancelled, nothing after is started
- uploadTooLarge copy no longer hardcodes a byte number (the host limit is
configurable); MAX_UPLOAD_BYTES is documented as a mirror, not authority
- relativePathOf rejects absolute paths (isAbsolutePath) instead of
stripping leading slashes, matching the host's 400 semantics
- progress text shared via uploadHintText for the hint and the overlay;
success-hint duration is the exported UPLOAD_HINT_MS
* feat(explorer): full-window upload progress with cancel and VSCode-style drop targets
- UploadOverlay: blurred scrim + card over the file window (Modal token
recipe: bg-mask-1 + mask blur, bg-layer-2, border-inverted, shadow-lv3),
file-level progress bar, cancel button and Esc; scrim clicks do not abort
- TreePanel owns the upload session: header pickers, tree drag-drop and the
context-menu picker funnel through startUpload; one session at a time
(buttons disabled while busy, drops guarded); on settle the tree refreshes
and the status hint shows success (3.5s, transient), failure or cancel
(error color, stays)
- FileTree: drops on directory rows target that directory, drops on FILE
rows target their parent (VSCode semantics, no more accidental root
uploads), root row and body drop into the workspace root; drag-over
highlights the target row (explorerRowDropTarget) plus the body outline
and a hint pill (uploadDropHint / uploadTo) — raw-color inline outline
replaced with the repo's dashed-accent classes
- upload status hint uses editorSearchHint + editorError like the search
status; duplicated upload flow removed from FileTree (single caller)
* test: register the upload route in the smoke inventory
The new /sidebar/upload route joined the fenced route list, so the mount
assertion must expect it (the PR's CI gate was red).
* chore: bump to 0.14.1
Rebased onto main and cut a release version for the upload feature:
package.json / dsh.plugin.json / SIDEBAR_SERVICE_VERSION stay in sync
(test-guarded), README changelogs get the v0.14.1 entry.
* feat(explorer): keep the drop hint above DSH's page overlay and suppress its intake over the tree
DSH's whole-page image-drop intake (ui-conversation InputBar) listens on
document in the bubble phase: any 'Files' drag entering the page shows its
full-screen overlay (z-1000) and a drop anywhere adds images to the chat.
Our tree handled dragover/drop but not dragenter, so the overlay flashed
over the file window and drops outside the tree rows could leak to the
chat.
- TreePanel root now swallows dragenter/dragover/drop (preventDefault +
stopPropagation) before the events reach document: the file window is an
upload target, not an image target. Row/body handlers still fire first
(bubble order) for their own targets; the root is the backstop for the
search row, gaps and the search-results view.
- The drop hint pill is portaled to document.body at z-index 1001 — above
DSH's overlay (z-1000) — so when a drag enters from outside the tree and
DSH's mask lingers until dragend, our 'Drop files/folders here' /
'Upload into {dir}' hint stays readable on top (transient decoration,
pointer-events none; the drop still lands on the tree).
* feat(explorer): zone-split the drop overlays and fix the mask flicker over the sidebar
Sidebar.tsx's panel host now swallows the whole file-drag quartet
(enter/over/leave/drop, gated on the 'Files' type): DSH's document-level
intake keeps an enter/leave depth counter, and the leaves that escaped
the tree unbalanced it — that was the native full-screen mask flickering
over the sidebar. The region is now a black hole to that listener, so the
conversation column keeps DSH's native overlay and image intake while the
sidebar presents its own upload surface (drops over it never add images
to the chat).
The tree's drop affordance is now a pointer-inert frame portaled to
document.body at z-1001, anchored to the explorer body's viewport rect:
it replaces DSH's mask over the sidebar instead of competing with it, and
the hint pill docks at the bottom edge so the rows — the actual drop
targets — stay visible and aimable instead of sitting behind a centered
pill. Inside the tree, enter/leave depth counting (InputBar's own
pattern) replaces the relatedTarget check, which is unreliable for drag
events and flickered the row highlight on icon/label transitions; the row
target is now set authoritatively by the continuously-firing dragover.
dragleave handlers on rows are gone.
Polish: capsule hint pill with the upload icon and a float shadow, the
progress overlay fades in (the repo's dsh-row-in motion), its title gains
the icon, and progress numbers render tabular. tests/file-tree-drop.spec
pins the depth-counter behavior (child transitions keep the zone) and the
parent-directory drop semantics.
* feat(explorer): dim the whole viewport behind the tree's drop zone
The bottom-docked pill sat below the fold of attention; the zone frame
alone also failed to teach the left/right split — a drag over the sidebar
gave no hint that the conversation column still accepts drops (into the
chat, natively). The zone frame now carries the full-viewport dim itself
(a 200vmax box-shadow spread in DSH's own mask-drop token): everything
outside the tree's rect fades, the tree stays clear and aimable, and a
muted invitation centered in the space left of the zone (skipped under
200px) names the chat as the image target. The pill moves to the TOP edge
of the zone, right under the search row — the first thing the eye meets.
* feat(explorer): colorful drop heroes for both zones
The overlay is this flow's one brand moment, so it gets the color the
rest of the UI never does: hand-drawn SVG illustrations in the palette of
DSH's own native drop art (#3964FE/#679EFE/#9CE5ED) so the two zones read
as one family. The upload zone docks a hero at its top edge — a tray
illustration over the hint pill, stacked so the rows below stay aimable;
the chat zone's invitation becomes a tilted photo-cards card over its
label.
* feat(explorer): traverse dropped folders instead of reading dataTransfer.files
A dropped OS folder never surfaces in dataTransfer.files (that flat list
carries files only), so folder drops were silent no-ops while the UI
advertised 'drop files/folders'. uploadItemsFromDrop now captures entry
handles via webkitGetAsEntry — synchronously, since the dataTransfer enters
protected mode once the drop dispatch ends, while the captured handles stay
readable — then drains each directory's readEntries batches recursively,
prefixing every descendant's relative path. Entry-derived paths go through
the same sanitizer as picker paths; an entry that fails to read is skipped
rather than failing the whole drop, and the flat file list remains the
fallback where the entry API is unavailable. The FileTree drop handlers
ride the resulting promise.
---------
Co-authored-by: dsh local <dsh@local>
Co-authored-by: Menghuan1918 <menghuan2003@outlook.com>
|
||
|
Atlas Zeng
|
6ee1ba11d0 |
feat(editor): 文件窗口与资源管理器二合一 + 声明式设置 select 行 (#151)
* feat(editor): merged explorer mode — path input, docked file tree, global name search
New editorExplorer pref (default on, editor card gear): the editor tab gains
a path-input header and a toggleable right-docked tree panel (per-tab state
in tab.meta.treeOpen; file tabs default closed, the seeded path-less home
tab defaults open). Fresh sessions seed that empty editor tab instead of
the explorer tab when merged mode is on; the standalone explorer tab stays
in the + menu unchanged.
- Extract FileTree.tsx from ExplorerView (shared by both hosts)
- Host fs.search route: recursive case-insensitive name search rooted at
the session cwd, budget-capped (200 matches / 100k visited), skips .git,
never descends symlink dirs
- EditorHost reads the pref reactively (boolean snapshot) and keeps the
pre-merge layout verbatim when off
* feat(settings): select row type for declarative settings; editorExplorer as iconed select
- SidebarSettingToggle gains type 'select' with options {value,title,desc,icon}
and multi (default false; stores the picked values as an array in options
order). Any option carrying an icon renders big-icon option cards in the
dropdown and the icon in the closed anchor; icon-less rows are one-line text.
- SelectRow in SideCardSection rides the primitives Menu (portal); single-pick
commits and closes, multi toggles and stays open. Wired for both host-prefs
toggles and plugin-owned pluginToggles via the new onSelectValue seam.
- The editorExplorer merged-mode pref is now an iconed select (merged vs
separate) instead of a switch; the stored value stays boolean.
- Advertise the capability as 'settingSelect' in SIDEBAR_FEATURES.
* feat(editor): unify explorer into the editor surface, resizable tree dock, hoisted toolbar
- One tree implementation, two presentations: the shared TreePanel (global
name search + refresh + FileTree) docks as the editor tab's right panel
and — in merged mode — fills the explorer tab's window; the pref-off
explorer keeps its legacy header shell.
- The docked panel drag-resizes from its left edge (160-480px clamp),
persisted as tab.meta.treeWidth alongside treeOpen.
- The text editor's preview/edit/save toolbar moves into the path-input
header row: FileViewerProps gains internal toolbar fields ('host' mode
skips the viewer's own row, reports EditorToolbarState and registers
EditorToolbarControls); non-merged mode is byte-identical to before.
* feat(editor): single files window with in-place switching; explorer descriptor removed
- editor tab replaces explorer on the + menu (order 10, Files); persisted
explorer tabs migrate to the editor home tab via sanitizeState
- editorExplorer now only controls open behavior: merged = in-place
updateTab, independent = openSidebarFile; both modes share the merged
chrome (path input + hoisted preview/edit/save toolbar + tree toggle)
- file tree context menu gains 'open in new tab' / 'open to the side'
(mintTabId avoids the id safety net; insertLeafAt splits right)
- tree dock resize uses pointer capture (touch-action none, 6px handle)
- defaults: openByDefault off, sidebar width 35%
- file tree clips horizontal overflow (no sideways scroll)
- e2e: mount lane arms the editor-chunk wait before goto and clicks the
tree row's left edge (hover @-reference button sits mid-row); drag lane
expands the panel first (collapsed push writes 0px), waits for the
slide-in to settle, and picks the leftmost col-resize strip; 'Files'
title assertions require draggable to skip the bottom panel's welcome
cards
* feat(editor): split mode turns the path-less window into the standalone explorer
In independent (split) mode a path-less files window renders ONLY the
tree panel (search + FileTree, full-window form) — no path input, no
hoisted toolbar, no tree toggle. File clicks open per-path editor tabs
(full chrome, tree docked closed by default) through openSidebarFile,
unchanged. Merged mode is untouched (chrome + docked tree, in-place
switching). TreePanel's previously reserved 'full' prop now has its
consumer.
|