Menghuan1918
22e772ce45
Issue #611 asked for file-type icons like the official explorer's, and #429 built a colored theme for them. DSH 0.1.5-rc.2 makes most of that work unnecessary: `@deepseek-ai/dsh-client-ui-primitives` now exports `FileTypeIcon` / `CodeFileIcon` with the host's own 48-type full-color code artwork plus category-colored sheet glyphs (and its classifier behind them). So the plugin renders the host's icons instead of shipping a color table, and color becomes the only behaviour rather than an opt-in theme. File icons (src/client/file-icons.tsx) - `builtinFileIcon(path, size)` → `<FileTypeIcon path size />`; folders use the host's folder category. The plugin's own per-extension VSCodicon map is gone. - The public `registerFileIcon` API from #531 is unchanged and still outranks the built-ins, so an external plugin can take over any row. One semantic consequence, now documented and tested: because the host classifier covers every path, a registered catch-all (`exts: []`) claims rows it used to lose to the built-in map. An unregistered catch-all (the old icon theme's shape) is unaffected. - Nothing is lazy any more: the artwork lives in a platform module the client already holds, so `lib/client-file-icons.js` and its 563-entry dataset (255 kB) are deleted outright — the core bundle grew by 10 kB (0.85 → 0.86 MB). - `src/client/file-icon-theme.ts`, the `fileIconTheme` pref (prefs-shared / config / client prefs), the settings-page select row and the six `settingsFileIconTheme*` keys in all 20 dictionaries are removed with it. Tab glyphs (src/client/builtins/tab-icons.tsx) - Every built-in tab type now declares a colored glyph: files (the host's folder artwork), changes/diff (commit), tasks (checklist), side chat (discussion), terminal (shell), browser (globe). - The color comes from a `--dsw-alias-*` token through a wrapper class, never from a literal — the skin contract (§12) holds and `tests/theme.spec.ts` enforces both halves (no literals in the module, every color declaration in the stylesheet resolves to a token). Native right Sidebar chips (src/client/native/tab-adapter.tsx) - The host's tab definition has no icon field, but the `sidebar.right.pane.tab.title` slot IS the chip's content, so the plugin draws the glyph itself: an editor tab with a path shows that file's icon, every other tab shows its descriptor's icon — the same `descriptor.icon` the workbench strip and the guide capsules already render, so the three cannot drift. The glyph is `aria-hidden`, which keeps the chip's accessible name exactly the title the mount lane matches on. Gates: typecheck / lint / check:consumer-types green; pnpm test 127 files / 1342 passed / 9 skipped (3 new chip cases, 1 rewritten built-in case).
63 lines
2.7 KiB
TypeScript
63 lines
2.7 KiB
TypeScript
/**
|
|
* Built-in file and folder glyphs for the file tree (feature: file icons).
|
|
*
|
|
* The built-in set is DSH's OWN file-type artwork: `FileTypeIcon` from
|
|
* `@deepseek-ai/dsh-client-ui-primitives` classifies a path and renders the
|
|
* same glyphs the host's own explorer shows — the 48 full-color code and
|
|
* configuration categories, plus the category-colored sheet glyphs for
|
|
* markdown, images, PDFs, office documents, video, folders and the generic
|
|
* fallback. Colored artwork is content, not chrome, and the host draws it
|
|
* with its own palette, so this module carries no color literals and stays
|
|
* inside the skin contract (the guide's §12).
|
|
*
|
|
* Nothing here needs a lazy chunk: the artwork belongs to a platform module
|
|
* the client already holds in its frozen module table, so the core bundle
|
|
* gains a function call rather than 500-odd icon rules.
|
|
*
|
|
* External plugins that want their own glyphs (per extension, per exact file
|
|
* name, per directory name) register `FileIconDescriptor`s through
|
|
* `ctx.betterSidebar.registerFileIcon`; their registrations win over these.
|
|
*/
|
|
import type { ReactNode } from 'react'
|
|
import { FileTypeIcon } from '@deepseek-ai/dsh-client-ui-primitives'
|
|
|
|
/**
|
|
* A file row: the host's own classifier and artwork for any path. Unknown
|
|
* extensions land on the generic document glyph, exactly like the host's
|
|
* explorer.
|
|
* @param path - the row's path (any separator; the classifier reads the basename).
|
|
* @param size - the square edge in px.
|
|
* @returns the host's file-type glyph.
|
|
*/
|
|
export function builtinFileIcon(path: string, size: number): ReactNode {
|
|
return <FileTypeIcon path={path} size={size} />
|
|
}
|
|
|
|
/**
|
|
* A directory row: the host's folder glyph.
|
|
*
|
|
* The host ships ONE folder drawing (`kind: 'folder'` resolves to its
|
|
* monochrome `IconFolderClose16`, which rides `currentColor` and therefore
|
|
* still follows the skin), and the classifier never returns a folder kind of
|
|
* its own. The expansion state is already legible from the tree's own chevron
|
|
* and row affordances, so this deliberately does not invent a second folder
|
|
* drawing.
|
|
* @param _open - whether the row is expanded (accepted for API compatibility).
|
|
* @param size - the square edge in px.
|
|
* @returns the host's folder glyph.
|
|
*/
|
|
export function builtinFolderIcon(_open: boolean, size: number): ReactNode {
|
|
return <FileTypeIcon kind="folder" size={size} />
|
|
}
|
|
|
|
/**
|
|
* The last-resort glyph: the host's generic document, for the resolver's leaf
|
|
* when no registration and no built-in match applies (and for surfaces that
|
|
* render a file row without a service).
|
|
* @param size - the square edge in px.
|
|
* @returns the host's generic file glyph.
|
|
*/
|
|
export function fallbackFileIcon(size: number): ReactNode {
|
|
return <FileTypeIcon kind="other" size={size} />
|
|
}
|