* feat(sidebar): 桌面兼容三方案——自动检测(WCO 标准几何)/壳预设/自定义 CSS 核心只保留 Web 标准机制,壳专属适配全部下沉到用户空间(KISS): - prefs 新增 titleBarScheme(默认 auto)/titleBarPresetId/customCss,旧 titleBarCompat 布尔自动迁移(true→custom 保留 stripPx,false/缺失→auto) - wco.ts:navigator.windowControlsOverlay 反应式几何(geometrychange 实时更新; visible=false 的幽灵 API 视为缺失),实现 #257 - titlebar-strip.ts 唯一 strip 取值链:WCO → dsh-desktop-titlebar-inset 契约参数 → 预设 stripFor → 手动 px → 0;desktop-env.ts 移除 win32 32px 硬编码 - shell-presets.ts 数据驱动预设(准入:issue/PR 提及 + 100+ star;v1 仅 anywhere-labs DSH Desktop:darwin 20px / win32 无 WCO 时 32px),opt-in 手动 - 预设/自定义 CSS 注入(data-dsh-preset-css / data-dsh-custom-css 标签), chrome 补稳定寻址面 data-dsh-toggle-cluster / data-dsh-panel - 交互 chrome 统一 -webkit-app-region: no-drag(吸收 #111/#153) - layout.css 底栏推挤复合锚点([data-pane] 与 :has(> [data-slot]) 双保险, rc.8 实测前者失效、后者命中,吸收 #226 思路) - 设置 UI:位置兼容模式齿轮弹窗改三方案(自动检测/壳兼容方案/自定义方案) - 测试:wco/titlebar-strip/shell-presets 单测 + prefs 迁移 + e2e 5 场景 (保守 auto/WCO 反应式/预设/自定义 CSS/复合锚点),挂载门禁 12/12 全绿 核心 grep 无壳专属类名;为某壳做的兼容在另一壳会再坏——预设与自定义 CSS 是唯一出路(AGENTS.md §8 契约已更新)。 * refine(sidebar): 位置兼容模式改主行下拉四选项——自动检测/DSH官方Web/壳预设/自定义 按用户反馈定稿 UI: - 主行下拉:自动检测(默认)/ DSH官方Web(显式零适配,连 WCO 也强制 0)/ 各壳预设(命中环境带「已检测」后缀,仅提示)/ 自定义方案(保留齿轮弹窗: 下移距离 + 自定义 CSS) - 旧文档迁移:titleBarCompat=true 或 titleBarStripPx 非默认值(此前已有配置) → 默认落到 custom 方案保留用户数值;干净文档 → auto - prefs 新增 'web' 方案;strip 取值链最优先处理 web→0 - 测试:prefs 迁移(stripPx 48→custom / 40→auto)、web 强制 0、下拉渲染断言 - 单测 693 通过,挂载 e2e 12/12 全绿 * refine(sidebar): 方案下拉复用 SelectMenu 组件,不用原生 <select> - 抽出可复用 SelectMenu(primitives Menu:锚点按钮 + 下拉选项卡,支持 icon/desc/多选),SelectRow 改为其薄壳 - 位置兼容模式方案下拉改用 SelectMenu;选项带描述(自动检测/DSH官方Web/ 各壳预设(命中带「已检测」后缀)/自定义方案) - 移除原生 select 样式;单测 693 通过,挂载 e2e 12/12 全绿
76 lines
3.7 KiB
TypeScript
76 lines
3.7 KiB
TypeScript
/**
|
|
* The title-bar strip resolution chain: standard WCO geometry first
|
|
* (authoritative even when 0), then the documented URL inset contract
|
|
* parameter, then the opt-in preset / custom scheme — and 0 (plain web,
|
|
* nothing modified) otherwise. No per-shell branch lives in the core.
|
|
*/
|
|
import { describe, expect, it } from 'vitest'
|
|
import { computeTitleBarStrip } from '../src/client/titlebar-strip.ts'
|
|
import type { DesktopEnv } from '../src/client/desktop-env.ts'
|
|
import type { WcoSnapshot } from '../src/client/wco.ts'
|
|
import type { ShellPreset } from '../src/client/shell-presets.ts'
|
|
|
|
const env = (partial: Partial<DesktopEnv>): DesktopEnv => ({
|
|
desktop: false,
|
|
mode: null,
|
|
platform: null,
|
|
titlebarInset: 0,
|
|
...partial,
|
|
})
|
|
|
|
const wco = (present: boolean, height = 0): WcoSnapshot => ({ present, height })
|
|
|
|
const noPreset: ShellPreset | undefined = undefined
|
|
|
|
describe('computeTitleBarStrip', () => {
|
|
it('keeps plain web untouched: no WCO, no inset, no scheme → 0', () => {
|
|
expect(computeTitleBarStrip(env({}), wco(false), 'auto', noPreset, 40)).toBe(0)
|
|
expect(computeTitleBarStrip(env({}), wco(false), 'custom', noPreset, 40)).toBe(40)
|
|
})
|
|
|
|
it('the explicit WEB scheme forces 0 — not even standard WCO geometry applies', () => {
|
|
const desktop = env({ desktop: true, mode: 'advanced', platform: 'win32' })
|
|
// The user declared "DSH official web": no adaptation at all, even when
|
|
// a real overlay exists or a preset is active.
|
|
expect(computeTitleBarStrip(desktop, wco(true, 36), 'web', noPreset, 40)).toBe(0)
|
|
expect(computeTitleBarStrip(desktop, wco(false), 'web', noPreset, 40)).toBe(0)
|
|
expect(computeTitleBarStrip(desktop, wco(false), 'web', {
|
|
id: 't', title: 't', desc: '', stripFor: () => 20,
|
|
}, 40)).toBe(0)
|
|
})
|
|
|
|
it('trusts the standard WCO geometry first in every scheme (even 0 — e.g. maximized)', () => {
|
|
const desktop = env({ desktop: true, mode: 'advanced', platform: 'win32' })
|
|
expect(computeTitleBarStrip(desktop, wco(true, 36), 'auto', noPreset, 0)).toBe(36)
|
|
expect(computeTitleBarStrip(desktop, wco(true, 36), 'preset', noPreset, 0)).toBe(36)
|
|
expect(computeTitleBarStrip(desktop, wco(true, 36), 'custom', noPreset, 40)).toBe(36)
|
|
// Authoritative zero: the overlay is hidden while maximized — no strip.
|
|
expect(computeTitleBarStrip(desktop, wco(true, 0), 'auto', noPreset, 40)).toBe(0)
|
|
})
|
|
|
|
it('applies the documented URL inset contract parameter before any scheme', () => {
|
|
const stamped = env({ desktop: true, mode: 'advanced', platform: 'darwin', titlebarInset: 20 })
|
|
expect(computeTitleBarStrip(stamped, wco(false), 'auto', noPreset, 0)).toBe(20)
|
|
expect(computeTitleBarStrip(stamped, wco(false), 'preset', noPreset, 0)).toBe(20)
|
|
})
|
|
|
|
it('uses the opt-in preset strip under the preset scheme only', () => {
|
|
const preset: ShellPreset = {
|
|
id: 't', title: 't', desc: '',
|
|
stripFor: (e) => e.platform === 'darwin' ? 20 : undefined,
|
|
}
|
|
const darwin = env({ desktop: true, mode: 'advanced', platform: 'darwin' })
|
|
expect(computeTitleBarStrip(darwin, wco(false), 'preset', preset, 0)).toBe(20)
|
|
// Auto never applies the preset — only standard signals.
|
|
expect(computeTitleBarStrip(darwin, wco(false), 'auto', preset, 0)).toBe(0)
|
|
// Custom never applies the preset either.
|
|
expect(computeTitleBarStrip(darwin, wco(false), 'custom', preset, 0)).toBe(0)
|
|
})
|
|
|
|
it('uses the manual strip px under the custom scheme only', () => {
|
|
expect(computeTitleBarStrip(env({}), wco(false), 'custom', noPreset, 56)).toBe(56)
|
|
expect(computeTitleBarStrip(env({}), wco(false), 'auto', noPreset, 56)).toBe(0)
|
|
expect(computeTitleBarStrip(env({}), wco(false), 'preset', noPreset, 56)).toBe(0)
|
|
})
|
|
})
|