* feat(editor): merged explorer mode — path input, docked file tree, global name search
New editorExplorer pref (default on, editor card gear): the editor tab gains
a path-input header and a toggleable right-docked tree panel (per-tab state
in tab.meta.treeOpen; file tabs default closed, the seeded path-less home
tab defaults open). Fresh sessions seed that empty editor tab instead of
the explorer tab when merged mode is on; the standalone explorer tab stays
in the + menu unchanged.
- Extract FileTree.tsx from ExplorerView (shared by both hosts)
- Host fs.search route: recursive case-insensitive name search rooted at
the session cwd, budget-capped (200 matches / 100k visited), skips .git,
never descends symlink dirs
- EditorHost reads the pref reactively (boolean snapshot) and keeps the
pre-merge layout verbatim when off
* feat(settings): select row type for declarative settings; editorExplorer as iconed select
- SidebarSettingToggle gains type 'select' with options {value,title,desc,icon}
and multi (default false; stores the picked values as an array in options
order). Any option carrying an icon renders big-icon option cards in the
dropdown and the icon in the closed anchor; icon-less rows are one-line text.
- SelectRow in SideCardSection rides the primitives Menu (portal); single-pick
commits and closes, multi toggles and stays open. Wired for both host-prefs
toggles and plugin-owned pluginToggles via the new onSelectValue seam.
- The editorExplorer merged-mode pref is now an iconed select (merged vs
separate) instead of a switch; the stored value stays boolean.
- Advertise the capability as 'settingSelect' in SIDEBAR_FEATURES.
* feat(editor): unify explorer into the editor surface, resizable tree dock, hoisted toolbar
- One tree implementation, two presentations: the shared TreePanel (global
name search + refresh + FileTree) docks as the editor tab's right panel
and — in merged mode — fills the explorer tab's window; the pref-off
explorer keeps its legacy header shell.
- The docked panel drag-resizes from its left edge (160-480px clamp),
persisted as tab.meta.treeWidth alongside treeOpen.
- The text editor's preview/edit/save toolbar moves into the path-input
header row: FileViewerProps gains internal toolbar fields ('host' mode
skips the viewer's own row, reports EditorToolbarState and registers
EditorToolbarControls); non-merged mode is byte-identical to before.
* feat(editor): single files window with in-place switching; explorer descriptor removed
- editor tab replaces explorer on the + menu (order 10, Files); persisted
explorer tabs migrate to the editor home tab via sanitizeState
- editorExplorer now only controls open behavior: merged = in-place
updateTab, independent = openSidebarFile; both modes share the merged
chrome (path input + hoisted preview/edit/save toolbar + tree toggle)
- file tree context menu gains 'open in new tab' / 'open to the side'
(mintTabId avoids the id safety net; insertLeafAt splits right)
- tree dock resize uses pointer capture (touch-action none, 6px handle)
- defaults: openByDefault off, sidebar width 35%
- file tree clips horizontal overflow (no sideways scroll)
- e2e: mount lane arms the editor-chunk wait before goto and clicks the
tree row's left edge (hover @-reference button sits mid-row); drag lane
expands the panel first (collapsed push writes 0px), waits for the
slide-in to settle, and picks the leftmost col-resize strip; 'Files'
title assertions require draggable to skip the bottom panel's welcome
cards
* feat(editor): split mode turns the path-less window into the standalone explorer
In independent (split) mode a path-less files window renders ONLY the
tree panel (search + FileTree, full-window form) — no path input, no
hoisted toolbar, no tree toggle. File clicks open per-path editor tabs
(full chrome, tree docked closed by default) through openSidebarFile,
unchanged. Merged mode is untouched (chrome + docked tree, in-place
switching). TreePanel's previously reserved 'full' prop now has its
consumer.
219 lines
9.6 KiB
TypeScript
219 lines
9.6 KiB
TypeScript
/**
|
||
* Shared "Side card" preference vocabulary (types + constants), consumed by
|
||
* BOTH halves: the host registers the schemastery schema over these values
|
||
* (config.ts) and the client reads/writes them through the settings RPC
|
||
* (client/prefs.ts, client/SideCardSection.tsx). Kept free of schemastery so
|
||
* the browser bundle never pulls the schema runtime in.
|
||
*/
|
||
|
||
/** The user-settings namespace holding the side card preferences. */
|
||
export const SIDEBAR_PREFS_NS = 'dsh-better-sidebar'
|
||
|
||
/** User-facing side card preferences (new-conversation defaults). */
|
||
export interface SidebarPrefs {
|
||
/** Whether a brand-new conversation opens the side card by default. */
|
||
openByDefault: boolean
|
||
/** Default panel width as a percent of the window width (20–60). */
|
||
defaultWidthPercent: number
|
||
/**
|
||
* Whether the sidebar auto-activates (opens the panel) and expands the
|
||
* Subagent page when the current conversation spawns a new subagent.
|
||
*/
|
||
autoOpenSubagent: boolean
|
||
/**
|
||
* Whether the sidebar auto-activates (opens the panel) and expands the
|
||
* Jobs page when a NEW background job appears for the current
|
||
* conversation (any new job id, not just the first one).
|
||
*/
|
||
autoOpenJobs: boolean
|
||
/**
|
||
* Whether the model-facing agent terminal tools (terminal_create / list /
|
||
* send / read / wait_for / resize / signal / close) are injected into the
|
||
* model's toolset. Off by default: the feature stays dormant until the
|
||
* user explicitly enables it in the side card settings.
|
||
*/
|
||
agentTerminalTools: boolean
|
||
/**
|
||
* Custom terminal font-family stack (a CSS font-family value, e.g.
|
||
* `'JetBrains Mono', monospace`). Empty string follows the app's theme
|
||
* monospace font (`--ds-font-family-code`). Applied live to every
|
||
* terminal tab; configured under the terminal card's secondary settings.
|
||
*/
|
||
terminalFontFamily: string
|
||
/**
|
||
* Custom terminal font size in px (9–32). Applied live to every terminal
|
||
* tab; configured under the terminal card's secondary settings.
|
||
*/
|
||
terminalFontSize: number
|
||
/**
|
||
* Whether expanding the bottom panel for the FIRST time in a session tries
|
||
* to open a fresh terminal tab there (the terminal quota/type still gates
|
||
* the attempt). On by default; the switch lives under the terminal tab's
|
||
* row in the Side card settings.
|
||
*/
|
||
bottomPanelAutoTerminal: boolean
|
||
/**
|
||
* Whether chat-side file opens (tool-row path links, the produced-files
|
||
* row, prose file mentions — every path that funnels through the client
|
||
* runtime's `ctx.workspaces.openPath`) open in the sidebar editor instead
|
||
* of the Host OS's default application. On by default; the editor tab's
|
||
* own enable switch gates it too (both must be on for the takeover).
|
||
*/
|
||
interceptOpenPath: boolean
|
||
/**
|
||
* Whether the editor tab runs in merged mode: a path input replaces the
|
||
* plain header and a toggleable file-tree panel (with a global name
|
||
* search) docks at the tab's right edge. On by default; also makes brand
|
||
* new sessions seed an empty editor tab (tree panel open) instead of the
|
||
* explorer tab. The switch lives under the editor card's gear in the
|
||
* Side card settings; off restores the pre-merge editor exactly.
|
||
*/
|
||
editorExplorer: boolean
|
||
/**
|
||
* Position compatibility mode: reserves space at the top for the native
|
||
* Windows title bar (drawn at the window's top-right corner over the web
|
||
* content in frameless/hidden-title-bar windows). When on, the toggle
|
||
* cluster drops below the strip and the right panel's content starts
|
||
* below it. Off by default — the sidebar layout is untouched.
|
||
*/
|
||
titleBarCompat: boolean
|
||
/**
|
||
* The reserved top strip height in px when `titleBarCompat` is on
|
||
* (0–120, default 40). Drives the `--dsh-title-bar-strip` CSS variable:
|
||
* the toggle cluster drops `strip + 3px` and the right panel's content
|
||
* starts `strip` px below its top edge.
|
||
*/
|
||
titleBarStripPx: number
|
||
/**
|
||
* Whether the HTML previewer drops its sandboxed iframe. Sandbox ON (the
|
||
* default) renders previewed HTML in an opaque-origin iframe that cannot
|
||
* touch the GUI; turning it OFF runs the previewed page with the GUI's
|
||
* own origin — full read/write access to session files and internal
|
||
* APIs. Only for trusted local content; the setting copy warns.
|
||
*/
|
||
htmlViewerNoSandbox: boolean
|
||
/**
|
||
* Whether a newly opened HTML preview starts UNSANDBOXED (the per-surface
|
||
* temporary unlock pre-applied). Off by default: previews open sandboxed
|
||
* and the status row offers the one-tap unlock; when on, previews open
|
||
* in the red unsandboxed state and the status row offers a one-tap
|
||
* restore for the current file.
|
||
*/
|
||
htmlViewerDefaultUnsafe: boolean
|
||
/**
|
||
* Whether the browser tab drops its sandboxed iframe. Sandbox ON (the
|
||
* default) keeps browsed sites in an opaque origin with no GUI access;
|
||
* turning it OFF runs any visited site with the GUI's own origin — it
|
||
* can read session data and act as the logged-in GUI. Only for trusted
|
||
* sites; the setting copy warns.
|
||
*/
|
||
browserNoSandbox: boolean
|
||
/**
|
||
* MASTER switch: whether clicking an EXTERNAL link in the GUI (chat
|
||
* messages, tool rows, prose mentions) is taken over into the sidebar at
|
||
* all. On by default; the per-protocol granularity lives in
|
||
* `browserInterceptHttp` / `browserInterceptHttps` (the protocol flag
|
||
* must also be on), and the target tab's own enable switch gates it too.
|
||
* Ctrl/Cmd+click always bypasses the takeover. Kept as the master so old
|
||
* documents keep their meaning with no migration (an explicit `false`
|
||
* stays "never take over").
|
||
*/
|
||
browserInterceptLinks: boolean
|
||
/**
|
||
* Whether clicking an http EXTERNAL link in the GUI opens the sidebar
|
||
* (the built-in browser tab, or a plugin tab that declares `urlTarget`)
|
||
* instead of a new browser tab. On by default; gated on the
|
||
* `browserInterceptLinks` master and the target tab's own enable switch.
|
||
*/
|
||
browserInterceptHttp: boolean
|
||
/**
|
||
* Whether clicking an https EXTERNAL link in the GUI opens the sidebar
|
||
* instead of a new browser tab. OFF by default — most https sites (e.g.
|
||
* GitHub) refuse iframe embedding, so the system browser is the smoother
|
||
* default; gated on the `browserInterceptLinks` master and the target
|
||
* tab's own enable switch.
|
||
*/
|
||
browserInterceptHttps: boolean
|
||
/**
|
||
* Per-tab enable switches, keyed by tab descriptor id (`'explorer'`,
|
||
* `'my-plugin:db'`). An ABSENT key means enabled — only an explicit
|
||
* `false` disables a tab type (hidden from the + menu, `openTab` refuses,
|
||
* and derived flows like subagent auto-open / agent-terminal tabs stop).
|
||
* Already-open tabs of a disabled type keep rendering (closing one
|
||
* prevents reopening), matching the "existing conversations keep their
|
||
* own layouts" rule.
|
||
*/
|
||
tabsEnabled: Record<string, boolean>
|
||
/**
|
||
* Per-viewer enable switches, keyed by file viewer descriptor id
|
||
* (`'image'`, `'my-plugin:csv'`). An ABSENT key means enabled; a disabled
|
||
* viewer is skipped by `matchFileViewer` so files fall through to the
|
||
* next matching viewer (or the download button when none match).
|
||
*/
|
||
viewersEnabled: Record<string, boolean>
|
||
/**
|
||
* Plugin-owned settings blobs (v0.12.0+), keyed by descriptor id: each
|
||
* registered tab/viewer that declares `settings.pluginToggles` (or writes
|
||
* through `settings.render`'s `updatePluginSetting`) persists its values
|
||
* here — an open map, so third-party keys need no host PrefsSchema field.
|
||
* Values are JSON-serializable (the row controls produce strings /
|
||
* numbers / booleans; custom panels are responsible for their own).
|
||
*/
|
||
pluginSettings: Record<string, Record<string, unknown>>
|
||
}
|
||
|
||
/** Range contract of {@link SidebarPrefs.defaultWidthPercent}. */
|
||
export const WIDTH_PERCENT_MIN = 20
|
||
export const WIDTH_PERCENT_MAX = 60
|
||
export const WIDTH_PERCENT_DEFAULT = 35
|
||
|
||
/** Range contract of {@link SidebarPrefs.terminalFontSize}. */
|
||
export const TERMINAL_FONT_SIZE_MIN = 9
|
||
export const TERMINAL_FONT_SIZE_MAX = 32
|
||
export const TERMINAL_FONT_SIZE_DEFAULT = 13
|
||
|
||
/** Range contract of {@link SidebarPrefs.titleBarStripPx}. */
|
||
export const TITLE_BAR_STRIP_MIN = 0
|
||
export const TITLE_BAR_STRIP_MAX = 120
|
||
export const TITLE_BAR_STRIP_DEFAULT = 40
|
||
|
||
/** Fallback prefs used whenever the settings document is unreachable or malformed. */
|
||
export const SIDEBAR_PREFS_DEFAULTS: SidebarPrefs = {
|
||
openByDefault: false,
|
||
defaultWidthPercent: WIDTH_PERCENT_DEFAULT,
|
||
autoOpenSubagent: true,
|
||
autoOpenJobs: true,
|
||
agentTerminalTools: false,
|
||
bottomPanelAutoTerminal: true,
|
||
terminalFontFamily: '',
|
||
terminalFontSize: TERMINAL_FONT_SIZE_DEFAULT,
|
||
interceptOpenPath: true,
|
||
editorExplorer: true,
|
||
titleBarCompat: false,
|
||
titleBarStripPx: TITLE_BAR_STRIP_DEFAULT,
|
||
htmlViewerNoSandbox: false,
|
||
htmlViewerDefaultUnsafe: false,
|
||
browserNoSandbox: false,
|
||
browserInterceptLinks: true,
|
||
browserInterceptHttp: true,
|
||
browserInterceptHttps: false,
|
||
tabsEnabled: {},
|
||
viewersEnabled: {},
|
||
pluginSettings: {},
|
||
}
|
||
|
||
/** Clamp one width percent into the contract range (shared by schema and client reads). */
|
||
export function clampWidthPercent(value: number): number {
|
||
return Math.min(WIDTH_PERCENT_MAX, Math.max(WIDTH_PERCENT_MIN, Math.round(value)))
|
||
}
|
||
|
||
/** Clamp one terminal font size into the contract range (shared by schema and client reads). */
|
||
export function clampTerminalFontSize(value: number): number {
|
||
return Math.min(TERMINAL_FONT_SIZE_MAX, Math.max(TERMINAL_FONT_SIZE_MIN, Math.round(value)))
|
||
}
|
||
|
||
/** Clamp one title-bar strip height into the contract range (shared by schema and client reads). */
|
||
export function clampTitleBarStrip(value: number): number {
|
||
return Math.min(TITLE_BAR_STRIP_MAX, Math.max(TITLE_BAR_STRIP_MIN, Math.round(value)))
|
||
}
|