* feat(editor): file tree 'open with' submenu (external editors, pin, SSH-remote, custom editors) The file tree right-click menu gains an 'Open with >' submenu with the resource manager (reveal in file manager), VS Code, Cursor and Zed, plus user-defined custom editors (name + URL template + VSCode-family flag). Each submenu row carries a pushpin that promotes the target to a direct top-level menu item. A configurable SSH host (settings: Files card gear) switches VSCode-family openers to <scheme>://vscode-remote/ssh-remote+<host>/<path> and hides host-local targets (file manager / Zed / non-VSCode custom editors). External opens run through the new fenced /sidebar/api/open.external route which spawns the platform opener with an argv array (no shell); the client never navigates raw scheme URLs itself. The settings seam's render panel now appends after the declarative rows instead of replacing them. * feat(editor): polish open-with menu UI — brand icons, pushpin, chevron, row alignment - Submenu rows: the custom label is now a block-level flex row filling the primitives itemLabel, so the pushpin docks at the row's far right (matching the trailing check of every other menu); menu row icons normalized to 16px (DSH native menus use 16, ours were 14). - The submenu parent row gains a right-aligned chevron (the primitives Menu renders no arrow for submenu parents). - Icons via react-icons: codicons VscPin/VscPinned pushpins (replacing the hand-drawn pin), VscFile/VscFolder/VscFolderOpened tree glyphs (replacing the </> file mark), VscLinkExternal for the open-with parent and the browser tab's open-external button (globally), SiCursor/SiZedindustries brand silhouettes; the VS Code mark is inlined from simple-icons@11.0.0 (CC0) as IconVscode16 since later simple-icons releases dropped it. All monochrome currentColor to follow the active skin. - tsdown: pin react-icons si/vsc to their ESM entries via resolve.alias — the package's exports map lists require before import, so the shared conditionNames picked the unshakeable CJS entry and bloated the core bundle by ~6.4 MB; tree-shaken it now adds only ~12 KB.
91 lines
3.7 KiB
TypeScript
91 lines
3.7 KiB
TypeScript
/**
|
|
* External open actions for the file tree's "open with" menu: hand a path to
|
|
* the OS file manager (reveal/select) or launch a URL scheme's registered
|
|
* handler (vscode://, cursor://, zed://, custom schemes).
|
|
*
|
|
* The client runs in a browser / DSH Desktop renderer where a raw `vscode://`
|
|
* navigation is unreliable, so both actions fan out through this host route
|
|
* and spawn the platform opener with an argv array (no shell interpolation).
|
|
* The command builders are pure — the platform is injectable — so every
|
|
* per-platform branch is unit-testable without spawning anything.
|
|
*/
|
|
import { spawn } from 'node:child_process'
|
|
import { parentOf, requireAbsolute } from './fs-tree.ts'
|
|
import { SidebarError } from './wire.ts'
|
|
|
|
/** The two external open actions the route accepts. */
|
|
export type OpenExternalAction = 'reveal' | 'url'
|
|
|
|
/** One platform opener invocation (argv array — never a shell string). */
|
|
export interface ExternalCommand {
|
|
command: string
|
|
args: string[]
|
|
}
|
|
|
|
/** Reveal/select a path in the OS file manager. On Linux there is no common
|
|
* select protocol — the containing directory is opened instead (KISS). */
|
|
export function revealCommand(path: string, platform: NodeJS.Platform = process.platform): ExternalCommand {
|
|
switch (platform) {
|
|
case 'darwin':
|
|
return { command: 'open', args: ['-R', path] }
|
|
// `explorer /select,<path>` — the classic "show in folder" incantation.
|
|
// Passed as separate argv entries (no shell); verify on Windows, with
|
|
// `cmd /c start "" explorer.exe "/select,<path>"` as the fallback.
|
|
case 'win32':
|
|
return { command: 'explorer.exe', args: ['/select,', path] }
|
|
default: {
|
|
const parent = parentOf(path)
|
|
return { command: 'xdg-open', args: [parent ?? path] }
|
|
}
|
|
}
|
|
}
|
|
|
|
/** Hand a custom-scheme URL to the OS protocol handler. */
|
|
export function urlCommand(url: string, platform: NodeJS.Platform = process.platform): ExternalCommand {
|
|
switch (platform) {
|
|
case 'darwin':
|
|
return { command: 'open', args: [url] }
|
|
// url.dll,FileProtocolHandler launches the registered protocol handler;
|
|
// `cmd /c start "" <url>` is the fallback if rundll32 misbehaves.
|
|
case 'win32':
|
|
return { command: 'rundll32.exe', args: ['url.dll,FileProtocolHandler', url] }
|
|
default:
|
|
return { command: 'xdg-open', args: [url] }
|
|
}
|
|
}
|
|
|
|
/** Validate a URL-scheme open target: a parseable custom-scheme URL (never
|
|
* http/https — those would only dump the URL into a browser tab). */
|
|
export function validateExternalUrl(raw: string): string {
|
|
if (!/^[a-z][a-z0-9+.-]*:\/\//i.test(raw)) {
|
|
throw new SidebarError('bad-request', 'url must be a custom-scheme URL')
|
|
}
|
|
let url: URL
|
|
try {
|
|
url = new URL(raw)
|
|
} catch {
|
|
throw new SidebarError('bad-request', 'invalid url')
|
|
}
|
|
if (url.protocol === 'http:' || url.protocol === 'https:') {
|
|
throw new SidebarError('bad-request', 'only custom-scheme urls can be opened externally')
|
|
}
|
|
return raw
|
|
}
|
|
|
|
/**
|
|
* Launch one external open action and return immediately (detached, no
|
|
* stdio). Spawn failures are reported through the child's 'error' event —
|
|
* by then the route already returned, so the event is swallowed (the OS
|
|
* dialog about a missing handler is the user-visible outcome either way).
|
|
*/
|
|
export function launchExternal(action: OpenExternalAction, value: string): { started: true } {
|
|
const platform = process.platform
|
|
const spec = action === 'reveal'
|
|
? revealCommand(requireAbsolute(value), platform)
|
|
: urlCommand(validateExternalUrl(value), platform)
|
|
const child = spawn(spec.command, spec.args, { detached: true, stdio: 'ignore' })
|
|
child.on('error', () => { /* opener missing/denied: handled by the OS */ })
|
|
child.unref()
|
|
return { started: true }
|
|
}
|