DSH 0.1.7-alpha.1 is 1299 commits past 0.1.6-alpha.2 and rewrites four
contracts this plugin was built on. The peer floor moves to
^0.1.7-alpha.1 (semver's prerelease rule means ^0.1.6-alpha.2 can never
match a 0.1.7 prerelease); 0.1.6-alpha.2 and earlier stay on v0.19.1.
Released as 0.21.0-alpha.1 (dist-tag alpha).
Hard breaks:
- dsh-settings was rewritten: register(ns, schema) is gone, a form is
addressed by the plugin row's Loader entry id and read from the
module's exported Config. The preferences are merged into Config and
marked volatile — which requires DSH's own schemastery, because only
that build wraps a volatile field in the cosmokit reference the
loader's volatile commit walks. With the public package a settings
write reports success and revision 1 while the effective value never
changes.
- ui-primitives renamed its whole icon family (IconXxx14/16 ->
IconXxxRegular/Medium): 26 imported symbols, 17 files. The failing
mode is render-time, not load-time. Five call sites that relied on the
old 14px default now pass size={14} explicitly.
- Session format v4 rejects source.kind === 'plugin'; the side-chat
boundary injection now writes plugin:dsh-better-sidebar, the same kind
DSH's own v3->v4 migration produces, so historical threads survive.
Tool results moved to role 'tool' with top-level content/isError; all
four parsers accept both shapes.
- The client session snapshot dropped subagentsByParent/jobsBySession
and the on-demand subagent-catalog observation API. The Tasks page
reads projectionsBySession and a new jobs.list route.
Yields and convergence:
- The read-only previews go to DSH's documentpreview (Office->PDF, a
spreadsheet worker, zoom, per-directory refresh); editor.canOpen
refuses those 26 extensions. Markdown, HTML (with its sandbox
switches) and the editable code buffer stay.
- The host browser kind is desktop-profile-only now, so the web e2e
lanes expect no browser entry and assert its absence.
- Link takeover claims only urlTarget links and passes the rest to the
host, fixing a regression from the 0.1.6 round: the fallback pointed
at a 'browser' type the plugin no longer registers, so http links in
its own markdown did nothing.
Also fixed, found along the way:
- The file tree refreshes live (new directory watch over the plugin's
own socket), since the plugin owns the `files` kind.
- ctx.sessions.list has no `current` field at either tag; the three
readers were dead. They now use ctx.sidebarRight.mounted.
- package.json.files was missing lib/client-locale.js.
- Two genuinely dead call sites: sessions.openSubagent/open/
refreshSubagents do not exist on the current baseline, so the
topology click, the jump-back and the retry were all no-ops.
- The test harness window shim lacked addEventListener, which the 0.1.7
primitives call at module-evaluation time; and the e2e token exchange
needs Playwright's request stack, not Node's fetch.
188 lines
7.7 KiB
TypeScript
188 lines
7.7 KiB
TypeScript
/**
|
|
* Host glue for the e2e lanes: page/asset URL construction, the authenticated
|
|
* request context, and the host RPC. The transport contracts (one-time-token
|
|
* launch URL, slash `/api` endpoints) live in ./host-protocol.ts; this
|
|
* module only wires them to Playwright.
|
|
*
|
|
* Every lane consumes the same contract:
|
|
* - `PAGE_URL` / `pageUrl({...})` for page.goto (the token URL performs the
|
|
* browser's token→cookie exchange),
|
|
* - `sidebarApi(path)` for the plugin's own public routes,
|
|
* - `createHostApi()` for an APIRequestContext carrying the auth cookie,
|
|
* - `hostRpc(api, 'workspace.create', {...})` for the host's unary RPC.
|
|
*/
|
|
import { expect, request, type APIRequestContext, type Page } from '@playwright/test'
|
|
import { parseLaunchUrl, pageUrlWith, rpcAttempt } from './host-protocol'
|
|
|
|
const envUrl = process.env.DSH_E2E_URL
|
|
if (!envUrl) {
|
|
throw new Error('DSH_E2E_URL is not set — boot a DSH web instance with the plugin mounted and point this lane at it (see scripts/e2e-mount.sh)')
|
|
}
|
|
// Re-bind with an explicit string type: closure bodies below do not inherit
|
|
// the guard's narrowing of envUrl.
|
|
const RAW_URL: string = envUrl
|
|
|
|
const LAUNCH = parseLaunchUrl(RAW_URL)
|
|
|
|
/** Origin for URL construction (a token URL would corrupt path joins). */
|
|
export const ORIGIN = LAUNCH.origin
|
|
|
|
/** page.goto target: the launch URL as printed (token included —
|
|
* navigating it exchanges the token for the cookie). */
|
|
export const PAGE_URL = LAUNCH.pageUrl
|
|
|
|
/** page.goto target with extra query stamps merged (token preserved). */
|
|
export function pageUrl(extra: Record<string, string>): string {
|
|
return pageUrlWith(RAW_URL, extra)
|
|
}
|
|
|
|
/** Absolute URL for the plugin's own (public, unauthenticated) API route. */
|
|
export function sidebarApi(path: string): string {
|
|
return `${ORIGIN}/sidebar/api/${path}`
|
|
}
|
|
|
|
/** Exchange the one-time launch token for the auth-cookie header pair: the
|
|
* token URL answers 303 with Set-Cookie (following the redirect would lose
|
|
* it, hence `redirect: 'manual'`). Pure aside from the injected fetch —
|
|
* unit tests stub it (tests/e2e-host-protocol.spec.ts). */
|
|
export async function exchangeLaunchCookie(
|
|
launchUrl: string,
|
|
fetchImpl: typeof fetch = fetch,
|
|
): Promise<string> {
|
|
const res = await fetchImpl(launchUrl, { redirect: 'manual' })
|
|
const setCookie = res.headers.get('set-cookie')
|
|
if (setCookie === null) {
|
|
throw new Error(`token exchange failed: HTTP ${res.status} carried no set-cookie — cannot authenticate /api seeding`)
|
|
}
|
|
return setCookie.split(';', 1)[0] ?? ''
|
|
}
|
|
|
|
/** The `name=value` pair of the auth cookie, once per process. */
|
|
let cookieHeader: string | undefined
|
|
|
|
/**
|
|
* Exchange the launch token through Playwright's own request stack.
|
|
*
|
|
* {@link exchangeLaunchCookie} takes any `fetch`, but the Node global one
|
|
* cannot stand in for a browser here: the host's static fallback answers a
|
|
* plain Node GET of the token URL with an empty `405` and no `Set-Cookie`
|
|
* (reproduced on both `0.1.5-rc.2` and `0.1.7-alpha.1`, so it is a harness
|
|
* quirk rather than a host regression), which left every later `/api` call
|
|
* unauthenticated and the lane's session seeding dead. Playwright's request
|
|
* context speaks enough of a browser shape to complete the exchange, and
|
|
* `maxRedirects: 0` keeps the `303` from being followed — following it drops
|
|
* the `Set-Cookie` this exists to capture.
|
|
* @param launchUrl - the token URL as printed by the host.
|
|
* @returns the `name=value` cookie pair.
|
|
*/
|
|
export async function exchangeLaunchCookieViaPlaywright(launchUrl: string): Promise<string> {
|
|
const context = await request.newContext()
|
|
try {
|
|
await context.get(launchUrl, { maxRedirects: 0 })
|
|
const [cookie] = (await context.storageState()).cookies
|
|
if (cookie === undefined) {
|
|
throw new Error('token exchange produced no cookie — cannot authenticate /api seeding')
|
|
}
|
|
return `${cookie.name}=${cookie.value}`
|
|
} finally {
|
|
await context.dispose()
|
|
}
|
|
}
|
|
|
|
/** The exchanged cookie pair, memoised for the process. */
|
|
async function authCookie(): Promise<string> {
|
|
cookieHeader ??= await exchangeLaunchCookieViaPlaywright(RAW_URL)
|
|
return cookieHeader
|
|
}
|
|
|
|
/** page.goto through the host auth. A plain navigation goes to PAGE_URL (the
|
|
* token URL performs the browser's exchange), but a STAMPED navigation
|
|
* cannot: the exchange answers `303 → /` and silently DROPS every sibling
|
|
* query param (the mount lane caught the desktop-shell stamps vanishing
|
|
* this way), so pre-seed the browser context with the exchanged cookie and
|
|
* navigate the stamped URL directly. Playwright gives every test a fresh
|
|
* context, so the seeding is per-call and idempotent. */
|
|
export async function gotoPage(page: Page, extra: Record<string, string> = {}): Promise<void> {
|
|
if (Object.keys(extra).length > 0) {
|
|
const header = await authCookie()
|
|
const eq = header.indexOf('=')
|
|
await page.context().addCookies([{
|
|
name: header.slice(0, eq),
|
|
value: header.slice(eq + 1),
|
|
url: ORIGIN,
|
|
}])
|
|
await page.goto(pageUrlWith(ORIGIN, extra), { waitUntil: 'domcontentloaded' })
|
|
return
|
|
}
|
|
await page.goto(pageUrl(extra), { waitUntil: 'domcontentloaded' })
|
|
}
|
|
|
|
/** Authenticated request context for host RPC seeding (cookie attached). */
|
|
export async function createHostApi(): Promise<APIRequestContext> {
|
|
return request.newContext({
|
|
baseURL: ORIGIN,
|
|
extraHTTPHeaders: { cookie: await authCookie() },
|
|
})
|
|
}
|
|
|
|
/** The unwrapped `result` of a successful host RPC. */
|
|
export interface HostRpcOk<T> {
|
|
ok: true
|
|
value: T
|
|
}
|
|
|
|
let rpcCounter = 0
|
|
|
|
/** Call a host unary RPC (`'workspace.create'`, `'session.create'`, …).
|
|
* Throws with the response body when the HTTP call or the envelope result
|
|
* fails — the lanes' seeding treats any failure as fatal, so the error text
|
|
* carries everything a report needs. */
|
|
export async function hostRpc<T = unknown>(
|
|
api: APIRequestContext,
|
|
method: string,
|
|
args: Record<string, unknown> = {},
|
|
): Promise<HostRpcOk<T>> {
|
|
const attempt = rpcAttempt(method, args)
|
|
rpcCounter += 1
|
|
const rpcId = `e2e-${method}-${rpcCounter}`
|
|
const res = await api.post(attempt.path, {
|
|
data: { type: 'client-request', rpcId, method: attempt.method, payload: attempt.payload },
|
|
})
|
|
const bodyText = await res.text()
|
|
if (!res.ok()) {
|
|
throw new Error(`hostRpc ${method} [${attempt.path}] HTTP ${res.status()}: ${bodyText.slice(0, 400)}`)
|
|
}
|
|
let envelope: { type?: string; result?: { ok: true; value: T } | { ok: false; error: unknown } }
|
|
try {
|
|
envelope = JSON.parse(bodyText) as typeof envelope
|
|
} catch {
|
|
throw new Error(`hostRpc ${method} [${attempt.path}]: non-JSON response: ${bodyText.slice(0, 400)}`)
|
|
}
|
|
const result = envelope.result
|
|
if (result === undefined || result.ok !== true) {
|
|
throw new Error(`hostRpc ${method} [${attempt.path}] envelope error: ${bodyText.slice(0, 400)}`)
|
|
}
|
|
return result
|
|
}
|
|
|
|
/**
|
|
* Send one message in the session the shell opened, so the conversation header
|
|
* (and the native right Sidebar's corner control) exists: DSH renders the
|
|
* header only for a session with content, while a freshly seeded blank
|
|
* session shows the empty hero.
|
|
*
|
|
* DSH 0.1.5's composer is a Lexical contenteditable — `fill()` writes the DOM
|
|
* but not the editor model, so the send button would stay disabled. Type real
|
|
* keys instead.
|
|
* @param page - the lane's page.
|
|
*/
|
|
export async function sendFirstMessage(page: Page): Promise<void> {
|
|
const composer = page.getByRole('textbox', { name: /^(Describe what you want to build|描述你想要构建)/ })
|
|
await expect(composer).toBeVisible({ timeout: 60_000 })
|
|
await composer.click()
|
|
await page.keyboard.type('mount lane smoke')
|
|
const send = page.getByRole('button', { name: /^(Send message|发送消息)$/ })
|
|
await expect(send).toBeEnabled({ timeout: 30_000 })
|
|
await send.click()
|
|
}
|