存量清理(首跑 141 errors / 21 warnings → 0 / 0): - 删除孤儿 disable:SideChatView / Sidebar / selection-popup 三处 exhaustive-deps 豁免与 chunk-artifact 的 no-new-func 豁免(多行理由注释把 disable-next-line 顶离了实报行;selection-popup 改为提取 popupOpen 标志真修复) - 死代码:未用导入(Sidebar×7、TextEditor、SideCardSection、config、fs-operations 及 6 个 spec)、sidechat-core 死累加器 total、chunk-loader.spec 死助手 registry、sidechat-seed-validation 死助手 toolResultMessage - 真实小修:agent-opens 三处 throw 补 cause;lazy-chunk any → ComponentType<P>(P extends object);service.ts claimed 初值改定值赋值;chunk-loader task / spec 内 etag / pendingLoad / snapshot 改 const;terminal-links 去掉字符类内多余转义;SubagentView catalogs 空兜底 useMemo 稳定标识;editor-host.spec 组件提出大写 FakeViewer(rules-of-hooks);pty-helpers.spec 内联 require 提升为静态导入;panel-host-css 注释里的零宽空格改为可见写法 - 依赖数组豁免(均带理由):granular scope 字段(EditorHost / PdfView / ChangesTab / GitLens×2)、job.status 粒度(SubagentView×2)、清理期读 ref、mount-only 注册等;ctx(挂载期恒定)直接入 deps(Sidebar×3)、TextEditor previewScroll 补 scope(幂等) - 刻意控制字符正则(conversation-draft / markdown-images)与宿主槽位 any 签名(context-types)以带理由豁免保留 接入: - Makefile:lint 目标(typecheck 旁),check 聚合补 lint 保持「对齐 CI」语义 - ci.yml ci / ci-windows 两 job 与 release.yml 在 Typecheck 后加 Lint 步骤(release 注释同步顺序)
90 lines
3.3 KiB
TypeScript
90 lines
3.3 KiB
TypeScript
/**
|
|
* Lazy chunk view wrapper: mounts a component that lives in a lazy chunk,
|
|
* showing a loading placeholder while the chunk script loads and an error +
|
|
* retry affordance on failure. Used by the built-in tab/viewer descriptors.
|
|
*
|
|
* Contract note: {@link lazyChunkComponent} returns a plain render-prop
|
|
* function — the descriptor contract is `component: (props) => ReactNode`,
|
|
* and the repo renders descriptors BOTH ways: Sidebar calls
|
|
* `descriptor.component(props)` directly, EditorHost renders it via
|
|
* `createElement`. The wrapper function body therefore contains no hooks;
|
|
* all state lives in the inner {@link LazyChunkView} component.
|
|
*/
|
|
import { createElement, useEffect, useState, type ComponentType, type ReactNode } from 'react'
|
|
import { loadChunk, type ChunkExports, type ChunkName } from './chunk-loader.ts'
|
|
import { t } from './locales.ts'
|
|
import css from './sidebar.module.css'
|
|
|
|
interface LazyChunkViewProps<P> {
|
|
chunk: ChunkName
|
|
/** Module-level-stable selector (an inline lambda would re-trigger the effect). */
|
|
pick: (mod: ChunkExports) => ComponentType<P> | undefined
|
|
props: P
|
|
}
|
|
|
|
function LazyChunkView<P extends object>({ chunk, pick, props }: LazyChunkViewProps<P>): ReactNode {
|
|
const [attempt, setAttempt] = useState(0)
|
|
const [state, setState] = useState<
|
|
| { status: 'loading' }
|
|
| { status: 'error'; message: string }
|
|
| { status: 'ready'; Comp: ComponentType<P> }
|
|
>({ status: 'loading' })
|
|
|
|
useEffect(() => {
|
|
let cancelled = false
|
|
setState({ status: 'loading' })
|
|
loadChunk(chunk).then((mod) => {
|
|
if (cancelled) return
|
|
const Comp = pick(mod)
|
|
if (Comp === undefined) {
|
|
setState({ status: 'error', message: `[dsh-better-sidebar] chunk "${chunk}" is missing its component` })
|
|
return
|
|
}
|
|
setState({ status: 'ready', Comp })
|
|
}).catch((error: unknown) => {
|
|
if (cancelled) return
|
|
setState({ status: 'error', message: error instanceof Error ? error.message : String(error) })
|
|
})
|
|
return () => { cancelled = true }
|
|
}, [chunk, pick, attempt])
|
|
|
|
if (state.status === 'loading') {
|
|
return <div className={css.editorPlaceholder}>{t('loading')}</div>
|
|
}
|
|
if (state.status === 'error') {
|
|
return (
|
|
<div className={css.editorError}>
|
|
<span>{state.message}</span>
|
|
<button
|
|
type="button"
|
|
className={css.terminalRetry}
|
|
onClick={() => { setAttempt(current => current + 1) }}
|
|
>
|
|
{t('terminalRetry')}
|
|
</button>
|
|
</div>
|
|
)
|
|
}
|
|
return createElement(state.Comp, props)
|
|
}
|
|
|
|
/**
|
|
* Build a descriptor-compatible lazy wrapper for a chunk-resident component.
|
|
* The returned function is the descriptor `component` itself: it returns an
|
|
* element and never calls hooks, so both invocation styles (plain function
|
|
* call and createElement/JSX render) work. `pick` must be a module-level
|
|
* function (stable identity) — an inline lambda would re-trigger the load
|
|
* effect on every render.
|
|
* @param chunk - the chunk name (see chunk-loader.ts).
|
|
* @param pick - select the component from the chunk's exports.
|
|
*/
|
|
export function lazyChunkComponent<P extends object>(
|
|
chunk: ChunkName,
|
|
pick: (mod: ChunkExports) => ComponentType<P> | undefined,
|
|
): (props: P) => ReactNode {
|
|
return (props: P) => createElement(
|
|
LazyChunkView as ComponentType<LazyChunkViewProps<P>>,
|
|
{ chunk, pick, props },
|
|
)
|
|
}
|