Merge pull request #151 from xiyanjun/docs/evaluate-json-ok

docs(skill): clarify bsk evaluate exit-code vs --json .ok semantics close #133
docs(skill): clarify bsk evaluate exit-code vs --json .ok semantics
2026-09-10 13:01:23 +08:00 · 2026-08-28 22:06:04 +08:00 · 2026-08-28 18:02:38 +08:00 · 2026-08-28 16:41:00 +08:00
2 changed files with 4 additions and 4 deletions
@@ -210,7 +210,7 @@ Both capture from the moment the tab is attached and read a bounded per-tab buff

 | Command | Summary |
 |---------|---------|
-| `bsk evaluate <expression>` | Run JS in agent tab (see red lines); JS throw → stderr, **exit 0** |
+| `bsk evaluate <expression>` | Run JS in agent tab (see red lines). JS throw → stderr, **exit 0** (RPC success); use `--json` and check `.ok` to detect JS errors |
 | `bsk wait-for-navigation` | Block until load/DOM idle/etc. (`--wait-until`, `--timeout`) |
 | `bsk wait-ms <duration>` | Sleep (`500ms`, `2s`, `1m`; **no** `--session`) |

@@ -294,7 +294,7 @@ bsk record stop [--output trace]   # terminal fallback if the browser panel is u

 | Code | Meaning | What to do |
 |------|---------|------------|
-| `0` | Success (including `evaluate` where JS threw but RPC succeeded) | Continue |
+| `0` | Success (including `evaluate` where JS threw but RPC succeeded) | Continue; for `evaluate`, check `--json` `.ok` to distinguish JS success from RPC success |
 | `1` | User error — bad args, unknown session, tab not in Agent Window, stale ref | Fix args; `bsk session list`; re-snapshot |
 | `2` | Protocol / transport — service unreachable, IPC failure | `bsk doctor`; check extension connected; retry the command |
 | `3` | Browser / CDP execution failed | Retry; simplify selector; check tab still open |
@@ -210,7 +210,7 @@ Both capture from the moment the tab is attached and read a bounded per-tab buff

 | Command | Summary |
 |---------|---------|
-| `bsk evaluate <expression>` | Run JS in agent tab (see red lines); JS throw → stderr, **exit 0** |
+| `bsk evaluate <expression>` | Run JS in agent tab (see red lines). JS throw → stderr, **exit 0** (RPC success); use `--json` and check `.ok` to detect JS errors |
 | `bsk wait-for-navigation` | Block until load/DOM idle/etc. (`--wait-until`, `--timeout`) |
 | `bsk wait-ms <duration>` | Sleep (`500ms`, `2s`, `1m`; **no** `--session`) |

@@ -294,7 +294,7 @@ bsk record stop [--output trace]   # terminal fallback if the browser panel is u

 | Code | Meaning | What to do |
 |------|---------|------------|
-| `0` | Success (including `evaluate` where JS threw but RPC succeeded) | Continue |
+| `0` | Success (including `evaluate` where JS threw but RPC succeeded) | Continue; for `evaluate`, check `--json` `.ok` to distinguish JS success from RPC success |
 | `1` | User error — bad args, unknown session, tab not in Agent Window, stale ref | Fix args; `bsk session list`; re-snapshot |
 | `2` | Protocol / transport — service unreachable, IPC failure | `bsk doctor`; check extension connected; retry the command |
 | `3` | Browser / CDP execution failed | Retry; simplify selector; check tab still open |
Author	SHA1	Message	Date
Zhang GH	7163f2f9b0	Merge pull request #151 from xiyanjun/docs/evaluate-json-ok docs(skill): clarify bsk evaluate exit-code vs --json .ok semantics close #133	2026-08-28 22:06:04 +08:00
xiyanjun	f96bd72c3c	docs(skill): clarify bsk evaluate exit-code vs --json .ok semantics The exit code reflects RPC success only, not JS success. Document that programmatic callers must use --json and check the .ok field to detect JS errors. Addresses the discoverability gap raised in issue #133.	2026-08-28 18:02:38 +08:00
Zhang GH	329c68054b	Merge pull request #150 from Tencent/codex/browser-eval-harness test: 增加可扩展的浏览器能力回归测试框架	2026-08-28 16:41:00 +08:00